Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 22bfeee

Browse files
committedApr 14, 2024
Auto merge of #122997 - matthiaskrgr:compiletest_ices, r=oli-obk
compiletest ice tracking see https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/where.20to.20mass-add.20known.20ices.20.2F.20merging.20glacier.20into.20rust/near/429082963 This will allow us to sunset most of https://github.com/rust-lang/glacier The rustc ices will be tracked directly inside the rust testsuite There are a couple of .sh tests remaining that I have not ported over yet. This adds `tests/crashes`, a file inside this directory MUST ice, otherwise it is considered test-fail. This will be used to track ICEs from glacier and the bugtracker. When someones pr accidentally fixes one of these ICEs, they can move the test from `crashes` into `ui` for example. I also added a new tidy lint that warns when a test inside `tests/crashes` does not have a `//@ known-bug: ` line the env var `COMPILETEST_VERBOSE_CRASHES` can be set to get exit code, stderr and stdout of a crash-test to aid debugging/adding tests.
2 parents 0d8b334 + 2ce487c commit 22bfeee

File tree

172 files changed

+3362
-7
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

172 files changed

+3362
-7
lines changed
 

‎src/bootstrap/src/core/build_steps/test.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1400,6 +1400,8 @@ impl Step for RunMakeSupport {
14001400

14011401
default_test!(Ui { path: "tests/ui", mode: "ui", suite: "ui" });
14021402

1403+
default_test!(Crashes { path: "tests/crashes", mode: "crashes", suite: "crashes" });
1404+
14031405
default_test!(RunPassValgrind {
14041406
path: "tests/run-pass-valgrind",
14051407
mode: "run-pass-valgrind",

‎src/bootstrap/src/core/builder.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -745,6 +745,7 @@ impl<'a> Builder<'a> {
745745
test::ExpandYamlAnchors,
746746
test::Tidy,
747747
test::Ui,
748+
test::Crashes,
748749
test::RunPassValgrind,
749750
test::Coverage,
750751
test::CoverageMap,

0 commit comments

Comments
 (0)
Please sign in to comment.