Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit b168790

Browse files
committedMar 17, 2024
fetch submodule before checking llvm stamp
Previously, we were checking the LLVM stamp before fetching the submodule which leads to not being able to compile llvm on submodule updates. Signed-off-by: onur-ozkan <[email protected]>
1 parent 1eb882e commit b168790

File tree

1 file changed

+2
-1
lines changed
  • src/bootstrap/src/core/build_steps

1 file changed

+2
-1
lines changed
 

‎src/bootstrap/src/core/build_steps/llvm.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -259,6 +259,8 @@ impl Step for Llvm {
259259

260260
/// Compile LLVM for `target`.
261261
fn run(self, builder: &Builder<'_>) -> LlvmResult {
262+
builder.update_submodule(&Path::new("src").join("llvm-project"));
263+
262264
let target = self.target;
263265
let target_native = if self.target.starts_with("riscv") {
264266
// RISC-V target triples in Rust is not named the same as C compiler target triples.
@@ -279,7 +281,6 @@ impl Step for Llvm {
279281
Err(m) => m,
280282
};
281283

282-
builder.update_submodule(&Path::new("src").join("llvm-project"));
283284
if builder.llvm_link_shared() && target.is_windows() {
284285
panic!("shared linking to LLVM is not currently supported on {}", target.triple);
285286
}

0 commit comments

Comments
 (0)
Please sign in to comment.