Skip to content

rustbuild: some x.py targets no longer print their dependencies being built #110506

@matthiaskrgr

Description

@matthiaskrgr
Member

When running x.py install for example, x.py would previously show the build (cargo) output when building cargo during x.py install, but that is no longer the case. Is that intentional?

....
Uplifting rustc (stage1 -> stage3)
Building tool cargo (stage2 -> stage3)
Building tool cargo-credential-1password (stage2 -> stage3)
Dist cargo-1.71.0-dev-x86_64-unknown-linux-gnu
	finished in 2.176 seconds
Install cargo stage2 (Some(x86_64-unknown-linux-gnu))

Activity

added
T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
C-bugCategory: This is a bug.
on Apr 18, 2023
albertlarsan68

albertlarsan68 commented on Apr 18, 2023

@albertlarsan68
Member

It's not intentional AFAIK, but I don't see a recent PR that could have broken this off the top of my head.
Do you have a commit/timeframe where this worked correctly?

matthiaskrgr

matthiaskrgr commented on Apr 18, 2023

@matthiaskrgr
MemberAuthor

Hmm I would guess it still worked last weekend?

jyn514

jyn514 commented on Apr 18, 2023

@jyn514
Member

Are you sure cargo is actually being built? stage2 -> stage3 makes me think it's using cached stage 2 artifacts.

matthiaskrgr

matthiaskrgr commented on Apr 18, 2023

@matthiaskrgr
MemberAuthor

Might be 103ed0e

matthiaskrgr

matthiaskrgr commented on Apr 18, 2023

@matthiaskrgr
MemberAuthor

Yes, I can see rustc building cargo and its deps in htop while x.py does not print any updates 😅

jyn514

jyn514 commented on Apr 18, 2023

@jyn514
Member

oh lol that would do it

cc @weihanglo

weihanglo

weihanglo commented on Apr 18, 2023

@weihanglo
Member

Sounds like we do need stream_cargo there? I'll put it back then!

albertlarsan68

albertlarsan68 commented on Apr 18, 2023

@albertlarsan68
Member

Is there not a try_run way of doing things?

jyn514

jyn514 commented on Apr 18, 2023

@jyn514
Member

Yes, there's a try_run, that would be best.

added a commit that references this issue on Apr 19, 2023
e85b026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-bugCategory: This is a bug.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @matthiaskrgr@weihanglo@jyn514@albertlarsan68

      Issue actions

        rustbuild: some x.py targets no longer print their dependencies being built · Issue #110506 · rust-lang/rust