Skip to content

Regression in derive-more-0.5.0, Rust 1.16 #40195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brson opened this issue Mar 1, 2017 · 5 comments
Closed

Regression in derive-more-0.5.0, Rust 1.16 #40195

brson opened this issue Mar 1, 2017 · 5 comments
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta.

Comments

@brson
Copy link
Contributor

brson commented Mar 1, 2017

brian@ip-10-145-43-250:~/dev/derive_more⟫ git remote -v
origin  https://github.com/JelteF/derive_more (fetch)
origin  https://github.com/JelteF/derive_more (push)
brian@ip-10-145-43-250:~/dev/derive_more⟫ git log -1
commit 0b09cf91a423a39c2f2de11158f4030fbe9f3766
Author: Jelte Fennema <[email protected]>
Date:   Thu Feb 2 20:02:33 2017 +0100

    Bump version to 0.5.0


     Running target/debug/deps/not-f8aa6b8c1c9746d1

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured

   Doc-tests derive_more

running 2 tests
test _0 ... FAILED
test _1 ... FAILED

failures:

---- _0 stdout ----
        error: expected item, found `;`
 --> <anon>:5:34
  |
5 | struct Point2D { x: i32, y: i32 };
  |                                  ^

error: aborting due to previous error(s)

thread 'rustc' panicked at 'Box<Any>', /buildslave/rust-buildbot/slave/beta-dist-rustc-linux/build/src/librustc/session/mod.rs:203
note: Run with `RUST_BACKTRACE=1` for a backtrace.

---- _1 stdout ----
        error[E0468]: an `extern crate` loading macros must be at the crate root
 --> <anon>:3:1
  |
3 | extern crate derive_more;
  | ^^^^^^^^^^^^^^^^^^^^^^^^^

error: aborting due to previous error(s)

thread 'rustc' panicked at 'Box<Any>', /buildslave/rust-buildbot/slave/beta-dist-rustc-linux/build/src/librustc/session/mod.rs:203


failures:
    _0
    _1

test result: FAILED. 0 passed; 2 failed; 0 ignored; 0 measured

error: test failed

brian@ip-10-145-43-250:/mnt2/dev⟫ rustc +beta -Vv
rustc 1.16.0-beta.2 (bc15d5281 2017-02-16)
binary: rustc
commit-hash: bc15d5281c07828e7e5ca31af2051347f62629f5
commit-date: 2017-02-16
host: x86_64-unknown-linux-gnu
release: 1.16.0-beta.2
LLVM version: 3.9

Not on 1.15.

cc JelteF

@brson brson added the regression-from-stable-to-beta Performance or correctness regression from stable to beta. label Mar 1, 2017
@brson
Copy link
Contributor Author

brson commented Mar 1, 2017

cc @jseyfried

@jseyfried
Copy link
Contributor

jseyfried commented Mar 1, 2017

I believe this doc test was always erroneous but wasn't collected and compiled before #37890.
c.f. internals post
cc @eddyb

@brson
Copy link
Contributor Author

brson commented Mar 2, 2017

Seems ok to break to me.

@brson
Copy link
Contributor Author

brson commented Mar 2, 2017

cc @JelteF

@brson brson closed this as completed Mar 2, 2017
@JelteF
Copy link
Contributor

JelteF commented Mar 2, 2017

Yes, that is correct. I think it was due to this issue though: rust-lang/cargo#3552

If 0.6.0 does build everything is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta.
Projects
None yet
Development

No branches or pull requests

3 participants