Skip to content

Implicit panic calls not collected during monomorphization #90405

@nbdd0121

Description

@nbdd0121
Contributor

Implicit panic calls can be generated from Assert MIR terminator, but they are not collected during monomorphization. This means that link error will occur if the panic functions are not codegenned with core crate, e.g. when it is marked inline.

This causes breakage in rust-lang/cargo#10019 when #90273 changes the function to be inline if panic_immediate_abort is set and exposes this issue.

Activity

nbdd0121

nbdd0121 commented on Oct 29, 2021

@nbdd0121
ContributorAuthor

@rustbot label: T-compiler A-codegen
@rustbot claim

added
A-codegenArea: Code generation
T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
on Oct 29, 2021
added a commit that references this issue on Nov 1, 2021
db062de
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

A-codegenArea: Code generationC-bugCategory: This is a bug.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    Participants

    @nbdd0121@rustbot

    Issue actions

      Implicit panic calls not collected during monomorphization · Issue #90405 · rust-lang/rust