From fcfc7963891db5c91035ea527ead2ef998d6781b Mon Sep 17 00:00:00 2001
From: Saleem Jaffer <saleem@acko.com>
Date: Sat, 9 Mar 2019 13:30:42 +0530
Subject: [PATCH 1/3] fixes rust-lang#56766
---
src/libsyntax/parse/parser.rs | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/src/libsyntax/parse/parser.rs b/src/libsyntax/parse/parser.rs
index fd5038a8614f2..5789d2d09200d 100644
--- a/src/libsyntax/parse/parser.rs
+++ b/src/libsyntax/parse/parser.rs
@@ -6630,6 +6630,22 @@ impl<'a> Parser<'a> {
self.expect(&token::OpenDelim(token::Brace))?;
let mut trait_items = vec![];
while !self.eat(&token::CloseDelim(token::Brace)) {
+ if let token::DocComment(_) = self.token {
+ if self.look_ahead(1,
+ |tok| tok == &token::Token::CloseDelim(token::Brace)) {
+ let mut err = self.diagnostic().struct_span_err_with_code(
+ self.span,
+ "found a documentation comment that doesn't document anything",
+ DiagnosticId::Error("E0584".into()),
+ );
+ err.help("doc comments must come before what they document, maybe a \
+ comment was intended with `//`?",
+ );
+ err.emit();
+ self.bump();
+ continue;
+ }
+ }
let mut at_end = false;
match self.parse_trait_item(&mut at_end) {
Ok(item) => trait_items.push(item),
From eaff0fe36fa9c6ff25492808750626167c80c3d9 Mon Sep 17 00:00:00 2001
From: Saleem Jaffer <saleem@acko.com>
Date: Wed, 13 Mar 2019 09:58:05 +0530
Subject: [PATCH 2/3] adding test
---
src/test/ui/parser/doc-inside-trait-item.rs | 6 ++++++
src/test/ui/parser/doc-inside-trait-item.stderr | 11 +++++++++++
2 files changed, 17 insertions(+)
create mode 100644 src/test/ui/parser/doc-inside-trait-item.rs
create mode 100644 src/test/ui/parser/doc-inside-trait-item.stderr
diff --git a/src/test/ui/parser/doc-inside-trait-item.rs b/src/test/ui/parser/doc-inside-trait-item.rs
new file mode 100644
index 0000000000000..897515d65bb8e
--- /dev/null
+++ b/src/test/ui/parser/doc-inside-trait-item.rs
@@ -0,0 +1,6 @@
+trait User{
+ fn test();
+ /// empty doc
+ //~^ ERROR found a documentation comment that doesn't document anything
+}
+fn main() {}
\ No newline at end of file
diff --git a/src/test/ui/parser/doc-inside-trait-item.stderr b/src/test/ui/parser/doc-inside-trait-item.stderr
new file mode 100644
index 0000000000000..261e27b6e0d18
--- /dev/null
+++ b/src/test/ui/parser/doc-inside-trait-item.stderr
@@ -0,0 +1,11 @@
+error[E0584]: found a documentation comment that doesn't document anything
+ --> $DIR/doc-inside-trait-item.rs:3:5
+ |
+LL | /// empty doc
+ | ^^^^^^^^^^^^^
+ |
+ = help: doc comments must come before what they document, maybe a comment was intended with `//`?
+
+error: aborting due to previous error
+
+For more information about this error, try `rustc --explain E0584`.
From d2584816254278cd844d4892f0acf563f2e7e207 Mon Sep 17 00:00:00 2001
From: Saleem Jaffer <saleem@acko.com>
Date: Wed, 13 Mar 2019 11:53:06 +0530
Subject: [PATCH 3/3] tidy test
---
src/test/ui/parser/doc-inside-trait-item.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/test/ui/parser/doc-inside-trait-item.rs b/src/test/ui/parser/doc-inside-trait-item.rs
index 897515d65bb8e..87b501bd2a2df 100644
--- a/src/test/ui/parser/doc-inside-trait-item.rs
+++ b/src/test/ui/parser/doc-inside-trait-item.rs
@@ -3,4 +3,4 @@ trait User{
/// empty doc
//~^ ERROR found a documentation comment that doesn't document anything
}
-fn main() {}
\ No newline at end of file
+fn main() {}