ProductDoctor: Group channel issues by purchasability vs shipping (#6547)

Author: mirekm

.changeset/silver-foxes-jump.md

@@ -0,0 +1,5 @@
+---
+"saleor-dashboard": patch
+---
+
+ProductDoctor: Group channel issues by purchasability vs shipping to mirror Saleor 3.23 stock-availability semantics

.github/workflows/deploy-cloud.yaml

@@ -52,7 +52,6 @@ jobs:
       ENABLED_SERVICE_NAME_HEADER: true
       ONBOARDING_USER_JOINED_DATE_THRESHOLD: ${{ vars.CLOUD_ONBOARDING_USER_JOINED_DATE_THRESHOLD }}
     steps:
-
       - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
         with:
           ref: refs/tags/${{ github.event.client_payload.ref }}
@@ -94,7 +93,7 @@ jobs:
   deploy:
     runs-on: ubuntu-24.04
     needs: [build]
-    
+
     environment:
       deployment: false
       name: deploy-cloud

locale/defaultMessages.json

@@ -4196,6 +4196,10 @@
     "context": "Charged transaction amount, data display header",
     "string": "Charged"
   },
+  "LYKO9m": {
+    "context": "Section heading for issues that affect order fulfillment (shipping zones, shipping methods)",
+    "string": "Shipping"
+  },
   "La3xKC": {
     "context": "Description of public API verification feature",
     "string": "Check if customers can actually purchase this product"
@@ -6180,6 +6184,10 @@
   "WY3IXU": {
     "string": "This code already exists"
   },
+  "WZ2kxO": {
+    "context": "Section heading for issues that affect whether a customer can purchase (warehouses, stock, channel listing, pricing)",
+    "string": "Purchasability"
+  },
   "WasHjQ": {
     "context": "voucher discount",
     "string": "Shipment"
@@ -7709,10 +7717,6 @@
     "context": "order transaction refund summary description",
     "string": "The refund amount is calculated automatically based on the items selected. You can modify it manually if needed."
   },
-  "f71A+Y": {
-    "context": "Title for delivery configuration section in channel",
-    "string": "Delivery configuration"
-  },
   "fDc5ys": {
     "context": "order transaction refund summary label",
     "string": "Selected products"

src/products/components/ProductDoctor/AvailabilityCard.test.tsx

@@ -74,6 +74,7 @@ describe("AvailabilityCard / DiagnosticSummaryBanner", () => {
       useLegacyShippingZoneStockAvailability: false,
       issues: [
         makeIssue({
+          category: "purchasability",
           id: "stock-outside-channel-warehouses",
           severity: "info",
           message: "Stranded stock",
@@ -102,11 +103,13 @@ describe("AvailabilityCard / DiagnosticSummaryBanner", () => {
     const diagnostics = baseDiagnostics({
       issues: [
         makeIssue({
+          category: "purchasability",
           id: "stock-outside-channel-warehouses",
           severity: "info",
           message: "Stranded stock — warehouse A",
         }),
         makeIssue({
+          category: "purchasability",
           id: "stock-outside-channel-warehouses",
           severity: "info",
           message: "Stranded stock — warehouse B",
@@ -140,8 +143,14 @@ describe("AvailabilityCard / DiagnosticSummaryBanner", () => {
     const diagnostics = baseDiagnostics({
       useLegacyShippingZoneStockAvailability: true,
       issues: [
-        makeIssue({ id: "no-stock", severity: "warning", message: "No stock" }),
         makeIssue({
+          category: "purchasability",
+          id: "no-stock",
+          severity: "warning",
+          message: "No stock",
+        }),
+        makeIssue({
+          category: "purchasability",
           id: "stock-outside-channel-warehouses",
           severity: "info",
           message: "Stranded stock",
@@ -207,12 +216,21 @@ describe("AvailabilityCard / StockAvailabilityModeIndicator", () => {
   });
 });
 
-// Synthetic issue factory for UI tests. Defaults to a genuine info-level
-// advisory (stranded stock — the only check that emits info severity) so
-// callers using `makeIssue({ severity: "info" })` get an unambiguously
-// realistic fixture. Tests that need warnings/errors override the id +
-// severity explicitly.
-const makeIssue = (overrides: Partial<AvailabilityIssue> = {}): AvailabilityIssue => ({
+/**
+ * Synthetic issue factory for UI tests. `category` must be passed explicitly
+ * — we deliberately avoid inferring it from `id` in the test layer because
+ * that would duplicate the production category mapping (which lives in
+ * `runAvailabilityChecks`) and silently miscategorize new issue types.
+ *
+ * Defaults to a genuine info-level advisory (stranded stock — the only check
+ * that emits `info` severity in production) so callers using
+ * `makeIssue({ category: "purchasability", severity: "info" })` get an
+ * unambiguously realistic fixture. Tests that need warnings/errors override
+ * the id + severity + message explicitly.
+ */
+const makeIssue = (
+  overrides: Partial<AvailabilityIssue> & Pick<AvailabilityIssue, "category">,
+): AvailabilityIssue => ({
   id: "stock-outside-channel-warehouses",
   severity: "info",
   channelId: "channel-1",
@@ -236,7 +254,10 @@ describe("AvailabilityCard channel header severity gating", () => {
     // Arrange — direct mode, single info advisory.
     const diagnostics = baseDiagnostics({
       useLegacyShippingZoneStockAvailability: false,
-      issues: [makeIssue({ severity: "info" })],
+      // Default fixture id (`stock-outside-channel-warehouses`) is a
+      // purchasability-category check; pair the override accordingly so the
+      // fixture stays internally consistent with production grouping.
+      issues: [makeIssue({ category: "purchasability", severity: "info" })],
       hasErrors: false,
       hasWarnings: false,
     });
@@ -262,7 +283,14 @@ describe("AvailabilityCard channel header severity gating", () => {
     // Arrange — legacy mode, one warning-level issue.
     const diagnostics = baseDiagnostics({
       useLegacyShippingZoneStockAvailability: true,
-      issues: [makeIssue({ id: "no-stock", severity: "warning", message: "No stock" })],
+      issues: [
+        makeIssue({
+          category: "purchasability",
+          id: "no-stock",
+          severity: "warning",
+          message: "No stock",
+        }),
+      ],
       hasErrors: false,
       hasWarnings: true,
     });
@@ -286,17 +314,32 @@ describe("AvailabilityCard channel header severity gating", () => {
 
   it("renders a visible count and the warning icon when multiple header-worthy issues exist alongside info advisories", () => {
     // Arrange — two warnings + two info advisories on the same channel.
+    // Both info advisories are stranded-stock fixtures since that's the only
+    // check that genuinely emits info severity after Option A (no-shipping-
+    // zones is now a warning in both modes).
     const diagnostics = baseDiagnostics({
       useLegacyShippingZoneStockAvailability: false,
       issues: [
-        makeIssue({ id: "no-stock", severity: "warning", message: "No stock" }),
-        makeIssue({ id: "no-warehouses", severity: "warning", message: "No warehouses" }),
         makeIssue({
+          category: "purchasability",
+          id: "no-stock",
+          severity: "warning",
+          message: "No stock",
+        }),
+        makeIssue({
+          category: "purchasability",
+          id: "no-warehouses",
+          severity: "warning",
+          message: "No warehouses",
+        }),
+        makeIssue({
+          category: "purchasability",
           id: "stock-outside-channel-warehouses",
           severity: "info",
           message: "Stranded stock A",
         }),
         makeIssue({
+          category: "purchasability",
           id: "stock-outside-channel-warehouses",
           severity: "info",
           message: "Stranded stock B",
@@ -325,9 +368,20 @@ describe("AvailabilityCard channel header severity gating", () => {
     const diagnostics = baseDiagnostics({
       useLegacyShippingZoneStockAvailability: true,
       issues: [
-        makeIssue({ id: "no-variants", severity: "error", message: "No variants" }),
-        makeIssue({ id: "no-stock", severity: "warning", message: "No stock" }),
         makeIssue({
+          category: "purchasability",
+          id: "no-variants",
+          severity: "error",
+          message: "No variants",
+        }),
+        makeIssue({
+          category: "purchasability",
+          id: "no-stock",
+          severity: "warning",
+          message: "No stock",
+        }),
+        makeIssue({
+          category: "purchasability",
           id: "stock-outside-channel-warehouses",
           severity: "info",
           message: "Info only",
@@ -611,3 +665,112 @@ describe("PublicApiVerificationBadge reassurance", () => {
     expect(screen.queryByTestId("verification-reassurance")).toBeNull();
   });
 });
+
+describe("AvailabilityChannelItem issue category sections", () => {
+  const renderExpandedChannel = (issues: AvailabilityIssue[]) => {
+    const diagnostics = baseDiagnostics({
+      issues,
+      hasErrors: issues.some(i => i.severity === "error"),
+      hasWarnings: issues.some(i => i.severity === "warning"),
+    });
+
+    render(<AvailabilityCard diagnostics={diagnostics} totalChannelsCount={1} />, {
+      wrapper: Wrapper,
+    });
+
+    fireEvent.click(screen.getByText("Default Channel"));
+  };
+
+  it("renders both category sections when issues span both purchasability and shipping", () => {
+    renderExpandedChannel([
+      makeIssue({
+        category: "purchasability",
+        id: "no-stock",
+        severity: "warning",
+        message: "No stock",
+      }),
+      makeIssue({
+        category: "shipping",
+        id: "no-shipping-zones",
+        severity: "info",
+        message: "No shipping zones",
+      }),
+    ]);
+
+    const sections = screen.getAllByTestId("issue-category-section");
+
+    expect(sections).toHaveLength(2);
+    expect(sections.map(s => s.getAttribute("data-test-category"))).toEqual([
+      "purchasability",
+      "shipping",
+    ]);
+  });
+
+  it("renders only the purchasability section when no shipping issues exist", () => {
+    renderExpandedChannel([
+      makeIssue({
+        category: "purchasability",
+        id: "no-variants",
+        severity: "error",
+        message: "No variants",
+      }),
+      makeIssue({
+        category: "purchasability",
+        id: "no-stock",
+        severity: "warning",
+        message: "No stock",
+      }),
+    ]);
+
+    const sections = screen.getAllByTestId("issue-category-section");
+
+    expect(sections).toHaveLength(1);
+    expect(sections[0]).toHaveAttribute("data-test-category", "purchasability");
+  });
+
+  it("renders only the shipping section when no purchasability issues exist", () => {
+    renderExpandedChannel([
+      makeIssue({
+        category: "shipping",
+        id: "no-shipping-zones",
+        severity: "info",
+        message: "No shipping zones",
+      }),
+    ]);
+
+    const sections = screen.getAllByTestId("issue-category-section");
+
+    expect(sections).toHaveLength(1);
+    expect(sections[0]).toHaveAttribute("data-test-category", "shipping");
+  });
+
+  it("groups multiple issues of the same category under one section", () => {
+    renderExpandedChannel([
+      makeIssue({
+        category: "purchasability",
+        id: "no-stock",
+        severity: "warning",
+        message: "No stock",
+      }),
+      makeIssue({
+        category: "purchasability",
+        id: "stock-outside-channel-warehouses",
+        severity: "info",
+        message: "Stranded stock",
+      }),
+      makeIssue({
+        category: "purchasability",
+        id: "no-warehouses",
+        severity: "warning",
+        message: "No warehouses",
+      }),
+    ]);
+
+    const sections = screen.getAllByTestId("issue-category-section");
+
+    expect(sections).toHaveLength(1);
+    expect(sections[0]).toHaveAttribute("data-test-category", "purchasability");
+    // All three callouts should be inside the single purchasability section.
+    expect(screen.getAllByTestId("availability-issue-callout")).toHaveLength(3);
+  });
+});