Don't allow pytest-subtests to upgrade pytest

Signed-off-by: Pedro Algarvio <[email protected]>

Author: s0undt3ch

.pylint-spelling-words

@@ -64,6 +64,7 @@ sids
 sitevars
 smartos
 str
+subtests
 sunos
 sys
 toml

noxfile.py

@@ -129,9 +129,16 @@ def tests(session):
         session.install(COVERAGE_VERSION_REQUIREMENT, silent=PIP_INSTALL_SILENT)
         pytest_version_requirement = os.environ.get("PYTEST_VERSION_REQUIREMENT") or None
         if pytest_version_requirement:
+            # Account that, under CI, when we test previous version of pytest
+            # we need to pin pytest-subtests to a lower version so that pytest
+            # itself does not get upgraded
+            pytest_requirements = []
             if not pytest_version_requirement.startswith("pytest"):
                 pytest_version_requirement = "pytest{}".format(pytest_version_requirement)
-            session.install(pytest_version_requirement, silent=PIP_INSTALL_SILENT)
+            pytest_requirements.append(pytest_version_requirement)
+            if pytest_version_requirement.startswith("pytest~=6"):
+                pytest_requirements.append("pytest-subtests<0.7.0")
+            session.install(*pytest_requirements, silent=PIP_INSTALL_SILENT)
         session.install("-e", ".", silent=PIP_INSTALL_SILENT)
         session.install("-r", os.path.join("requirements", "base.txt"), silent=PIP_INSTALL_SILENT)
         session.install("-r", os.path.join("requirements", "tests.txt"), silent=PIP_INSTALL_SILENT)