Skip to content

Commit f67cb2a

Browse files
committed
fix(pkg): index
1 parent 5c09716 commit f67cb2a

File tree

5 files changed

+1023
-684
lines changed

5 files changed

+1023
-684
lines changed

dune/nft/trades/README.md

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,32 +1,34 @@
11
# Notes for users of `nft.trades`
22

3-
This repo collects trade data of NFT marketplaces in a single table `nft.trades`.
3+
This repo collects trade data of NFT marketplaces in a single table `nft.trades`.
44

5-
The goal is to enable a powerful new wave of Dune dashboards on NFTs, and inspire new contributors to add more marketplaces and NFT data.
5+
The goal is to enable a powerful new wave of Dune dashboards on NFTs, and inspire new contributors to add more marketplaces and NFT data.
66

77
ERC721 and ERC1155 `transfer` data is integrated for every trade transaction to enable analysis of trades consisting of multiple NFTs.
88

99
Known limitations:
10+
1011
- OpenSea and Rarible support non-ETH trades. Some of the tokens used for these transactions are not in Dune's `prices.usd`. In these cases, the `usd_amount` is `NULL`. At the time of writing (July 2021), for OpenSea and Rarible, the percentage of rows with missing USD values is 2% or less.
1112
- In some cases, there are rounding errors on the `original_amount` fields.
1213

13-
1414
# Notes for contributors to `nft.trades`
1515

1616
Here are some things to check before doing your pull request:
17+
1718
- As much as possible, verify data from the NFT page on the market place itself as well as on Etherscan. In one case, we noticed that event log data was not correctly decoded in case the trade was done in WETH instead of ETH.
1819
- Verify buyer and seller. In some scenario's (again when currency is not ETH) these get inversed. A good way to double-check is to verify against ERC721 transfers.
19-
- Different types of trades ("Direct Purchase", "Offer Accepted", "Auction Settled"...) often have a different encoding in the event logs.
20+
- Different types of trades ("Direct Purchase", "Offer Accepted", "Auction Settled"...) often have a different encoding in the event logs.
2021

2122
Don't hesitate to ask for help in Discord if you get stuck: https://discord.gg/ppntYkQu
2223

23-
2424
# Credits
2525

2626
Amazing pioneer work on NFTs by the following Dune users:
27+
2728
- https://duneanalytics.com/rchen8
2829
- https://duneanalytics.com/keeganead
2930

30-
The following power users helped me in various ways along the way:
31+
The following power users helped me in various ways along the way:
32+
3133
- https://duneanalytics.com/0xBoxer
3234
- https://duneanalytics.com/danner_eth

0 commit comments

Comments
 (0)