Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: sequelize/cli
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v6.6.1
Choose a base ref
...
head repository: sequelize/cli
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v6.6.2
Choose a head ref
3 contributors
Loading
Showing with 1,286 additions and 1,418 deletions.
  1. +8 −8 .github/workflows/ci.yml
  2. +1 −1 .github/workflows/codeql-analysis.yml
  3. +10 −10 package.json
  4. +5 −4 src/helpers/config-helper.js
  5. +1,262 −1,395 yarn.lock
16 changes: 8 additions & 8 deletions .github/workflows/ci.yml
View file
Original file line number Diff line number Diff line change
@@ -20,8 +20,8 @@ jobs:
DIALECT: postgres
SEQ_PORT: 54320
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
- run: yarn install --frozen-lockfile --ignore-engines
@@ -41,8 +41,8 @@ jobs:
DIALECT: mysql
SEQ_PORT: 33060
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
- run: yarn install --frozen-lockfile --ignore-engines
@@ -61,8 +61,8 @@ jobs:
env:
DIALECT: sqlite
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
- run: yarn install --frozen-lockfile --ignore-engines
@@ -82,8 +82,8 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 18.x
- run: yarn install --frozen-lockfile
2 changes: 1 addition & 1 deletion .github/workflows/codeql-analysis.yml
View file
Original file line number Diff line number Diff line change
@@ -20,7 +20,7 @@ jobs:
language: [ 'javascript' ]
steps:
- name: Checkout repository
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Initialize CodeQL
uses: github/codeql-action/init@v2
with:
20 changes: 10 additions & 10 deletions package.json
View file
Original file line number Diff line number Diff line change
@@ -21,27 +21,27 @@
"yargs": "^16.2.0"
},
"devDependencies": {
"@babel/cli": "7.21.5",
"@babel/core": "7.22.1",
"@babel/preset-env": "7.22.4",
"@babel/register": "7.21.0",
"@commitlint/cli": "17.6.5",
"@commitlint/config-angular": "17.6.5",
"@babel/cli": "7.23.0",
"@babel/core": "7.23.2",
"@babel/preset-env": "7.23.2",
"@babel/register": "7.22.15",
"@commitlint/cli": "18.2.0",
"@commitlint/config-angular": "18.1.0",
"bluebird": "3.7.2",
"eslint": "7.32.0",
"eslint-config-prettier": "8.8.0",
"eslint-config-prettier": "9.0.0",
"eslint-plugin-prettier": "4.2.1",
"expect.js": "0.3.1",
"gulp": "4.0.2",
"husky": "8.0.3",
"lint-staged": "13.2.2",
"lint-staged": "15.0.2",
"mocha": "9.2.2",
"mysql2": "3.2.0",
"pg": "latest",
"pg-hstore": "latest",
"prettier": "2.8.8",
"semver": "7.5.1",
"sequelize": "6.32.0",
"semver": "7.5.4",
"sequelize": "6.33.0",
"sqlite3": "latest",
"through2": "4.0.2"
},
9 changes: 5 additions & 4 deletions src/helpers/config-helper.js
View file
Original file line number Diff line number Diff line change
@@ -181,10 +181,11 @@ const api = {
};

if (urlParts.auth) {
result = _.assign(result, {
username: urlParts.auth.split(':')[0],
password: urlParts.auth.split(':')[1],
});
const authParts = urlParts.auth.split(':');
result.username = authParts[0];
if (authParts.length > 1) {
result.password = authParts.slice(1).join(':');
}
}

return result;
Loading