Skip to content

Commit 9408b02

Browse files
authored
Test deployments fixes (paritytech#2057)
* Fix node_impl_version error ``` error: unexpected argument '--node-impl-version' found tip: to pass '--node-impl-version' as a value, use '-- --node-impl-version' Usage: rialto-bridge-node prepare-worker <SOCKET_PATH> <NODE_IMPL_VERSION> For more information, try '--help'. ``` * Fix rialto-parachain not producing blocks We must have at least 2 validators for each collator
1 parent 9223136 commit 9408b02

File tree

2 files changed

+15
-5
lines changed

2 files changed

+15
-5
lines changed

bin/rialto/node/src/cli.rs

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,21 +68,25 @@ pub enum Subcommand {
6868
Inspect(node_inspect::cli::InspectCmd),
6969

7070
/// Benchmark runtime pallets.
71-
#[clap(subcommand)]
71+
#[command(subcommand)]
7272
Benchmark(frame_benchmarking_cli::BenchmarkCmd),
7373

7474
/// FOR INTERNAL USE: analog of the "prepare-worker" command of the polkadot binary.
75-
#[clap(name = "prepare-worker", hide = true)]
75+
#[command(name = "prepare-worker", hide = true)]
7676
PvfPrepareWorker(ValidationWorkerCommand),
7777

7878
/// FOR INTERNAL USE: analog of the "execute-worker" command of the polkadot binary.
79-
#[clap(name = "execute-worker", hide = true)]
79+
#[command(name = "execute-worker", hide = true)]
8080
PvfExecuteWorker(ValidationWorkerCommand),
8181
}
8282

8383
/// Validation worker command.
8484
#[derive(Debug, Parser)]
8585
pub struct ValidationWorkerCommand {
8686
/// The path to the validation host's socket.
87+
#[arg(long)]
8788
pub socket_path: String,
89+
/// Calling node implementation version
90+
#[arg(long)]
91+
pub node_impl_version: String,
8892
}

bin/rialto/node/src/command.rs

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -164,15 +164,21 @@ pub fn run() -> sc_cli::Result<()> {
164164
builder.with_colors(false);
165165
let _ = builder.init();
166166

167-
polkadot_node_core_pvf::prepare_worker_entrypoint(&cmd.socket_path, None);
167+
polkadot_node_core_pvf::prepare_worker_entrypoint(
168+
&cmd.socket_path,
169+
Some(&cmd.node_impl_version),
170+
);
168171
Ok(())
169172
},
170173
Some(crate::cli::Subcommand::PvfExecuteWorker(cmd)) => {
171174
let mut builder = sc_cli::LoggerBuilder::new("");
172175
builder.with_colors(false);
173176
let _ = builder.init();
174177

175-
polkadot_node_core_pvf::execute_worker_entrypoint(&cmd.socket_path, None);
178+
polkadot_node_core_pvf::execute_worker_entrypoint(
179+
&cmd.socket_path,
180+
Some(&cmd.node_impl_version),
181+
);
176182
Ok(())
177183
},
178184
None => {

0 commit comments

Comments
 (0)