lib/gshadow.c: fgetsgent(): Don't use static variables

BTW, getline(3) says we must free(3) the buffer on error.

Reported-by: Chris Hofstaedtler <[email protected]>
Signed-off-by: Alejandro Colomar <[email protected]>

Author: alejandro-colomar

lib/gshadow.c

@@ -123,19 +123,28 @@ sgetsgent(const char *s)
 /*@observer@*//*@null@*/struct sgrp *
 fgetsgent(/*@null@*/FILE *fp)
 {
-	static size_t buflen = 0;
-	static char *buf = NULL;
+	char         *buf;
+	size_t       buflen;
+	struct sgrp  *sg;
 
 	if (NULL == fp) {
 		return NULL;
 	}
 
+	buf = NULL;
+	buflen = 0;
 	if (getline(&buf, &buflen, fp) == -1)
-		return NULL;
+		goto fail;
 	if (stpsep(buf, "\n") == NULL)
-		return NULL;
+		goto fail;
+
+	sg = sgetsgent(buf);
 
-	return (sgetsgent (buf));
+	free(buf);
+	return sg;
+fail:
+	free(buf);
+	return NULL;
 }