Skip to content

Commit 0430f56

Browse files
electrovirsom-sm
andauthored
PackageJson: Fix key type for DependencyOverrides (#1307)
Co-authored-by: Som Shekhar Mukherjee <iamssmkhrj@gmail.com>
1 parent d299810 commit 0430f56

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

source/package-json.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@ export namespace PackageJson {
212212
Recursive map describing selective dependency version overrides supported by npm.
213213
*/
214214
type DependencyOverrides = {
215-
[packageName: string]: string | undefined | DependencyOverrides;
215+
[packageName in string]: string | undefined | DependencyOverrides;
216216
};
217217

218218
/**

test-d/package-json.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,12 +36,14 @@ expectType<PackageJson.Dependency | undefined>(packageJson.peerDependencies);
3636
expectType<string[] | undefined>(packageJson.bundleDependencies);
3737
expectType<string[] | undefined>(packageJson.bundledDependencies);
3838
expectType<PackageJson.Dependency | undefined>(packageJson.resolutions);
39+
expectType<keyof PackageJson.Dependency>({} as string);
3940
expectType<PackageJson.WorkspaceConfig | string[] | undefined>(packageJson.workspaces);
4041
expectAssignable<PackageJson['overrides']>({foo: '1.0.0'});
4142
expectAssignable<PackageJson['overrides']>({foo: {'.': '1.0.0', bar: '1.0.0'}});
4243
expectAssignable<PackageJson['overrides']>({baz: {bar: {foo: '1.0.0'}}});
4344
expectAssignable<PackageJson['overrides']>({foo: undefined});
4445
expectAssignable<PackageJson['overrides']>({foo: {bar: undefined}});
46+
expectType<keyof PackageJson.DependencyOverrides>({} as string);
4547
expectAssignable<PackageJson.DevEngineDependency>({
4648
name: 'unicorn',
4749
version: '>= 1.0.0',

0 commit comments

Comments
 (0)