fix: make validation agnostic of union order

Author: som-sm

lint-rules/validate-jsdoc-codeblocks.js

@@ -229,18 +229,14 @@ function normalizeUnions(type) {
 	const typeNode = sourceFile.statements[0].declarationList.declarations[0].type;
 
 	const print = node => ts.createPrinter().printNode(ts.EmitHint.Unspecified, node, sourceFile);
-	const isNumeric = v => v.trim() !== '' && Number.isFinite(Number(v));
 
 	const visit = node => {
 		node = ts.visitEachChild(node, visit, undefined);
 
 		if (ts.isUnionTypeNode(node)) {
 			const types = node.types
 				.map(t => [print(t), t])
-				.sort(([a], [b]) =>
-					// Numbers are sorted only wrt other numbers
-					isNumeric(a) && isNumeric(b) ? Number(a) - Number(b) : 0,
-				)
+				.sort(([a], [b]) => a < b ? -1 : 1)
 				.map(t => t[1]);
 
 			return ts.factory.updateUnionTypeNode(
@@ -311,19 +307,10 @@ function validateTwoslashTypes(context, env, code, codeStartIndex) {
 			const quickInfo = env.languageService.getQuickInfoAtPosition(FILENAME, previousLineOffset + i);
 
 			if (quickInfo?.displayParts) {
-				let expectedType = normalizeUnions(extractTypeFromQuickInfo(quickInfo));
-
-				if (expectedType.length < 80) {
-					expectedType = expectedType
-						.replaceAll(/\r?\n\s*/g, ' ') // Collapse into single line
-						.replaceAll(/{\s+/g, '{') // Remove spaces after `{`
-						.replaceAll(/\s+}/g, '}') // Remove spaces before `}`
-						.replaceAll(/;(?=})/g, ''); // Remove semicolons before `}`
-				}
-
-				const expectedComment = TWOSLASH_COMMENT + ' ' + expectedType.replaceAll('\n', '\n// ');
+				const expectedType = normalizeUnions(extractTypeFromQuickInfo(quickInfo));
+				const actualType = normalizeUnions(actualComment.slice(TWOSLASH_COMMENT.length).replaceAll('\n// ', '\n'));
 
-				if (actualComment !== expectedComment) {
+				if (actualType !== expectedType) {
 					const actualCommentIndex = line.indexOf(TWOSLASH_COMMENT);
 
 					const actualCommentStartOffset = sourceFile.getPositionOfLineAndCharacter(index, actualCommentIndex);
@@ -332,6 +319,16 @@ function validateTwoslashTypes(context, env, code, codeStartIndex) {
 					const start = codeStartIndex + actualCommentStartOffset;
 					const end = codeStartIndex + actualCommentEndOffset;
 
+					const collapsedExpectedType = expectedType.length >= 80
+						? expectedType
+						: expectedType
+							.replaceAll(/\r?\n\s*/g, ' ') // Collapse into single line
+							.replaceAll(/{\s+/g, '{') // Remove spaces after `{`
+							.replaceAll(/\s+}/g, '}') // Remove spaces before `}`
+							.replaceAll(/;(?=})/g, ''); // Remove semicolons before `}`
+
+					const expectedComment = TWOSLASH_COMMENT + ' ' + collapsedExpectedType.replaceAll('\n', '\n// ');
+
 					context.report({
 						loc: {
 							start: context.sourceCode.getLocFromIndex(start),