feat: add integration tests for semantic views (#3978)

<!-- Feel free to delete comments as you fill this in -->

<!-- summary of changes -->

## Test Plan
<!-- detail ways in which this PR has been tested or needs to be tested
-->
* [ ] acceptance tests
<!-- add more below if you think they are relevant -->
* [ ] …

## References
<!-- issues documentation links, etc  -->

*

---------

Co-authored-by: shreyas <[email protected]>

Author: sfc-gh-sarur

pkg/acceptance/bettertestspoc/assert/objectassert/gen/sdk_object_def.go

@@ -137,6 +137,11 @@ var allStructs = []SdkObjectDef{
 		ObjectType:   sdk.ObjectTypeListing,
 		ObjectStruct: sdk.Listing{},
 	},
+	{
+		IdType:       "sdk.SchemaObjectIdentifier",
+		ObjectType:   sdk.ObjectTypeSemanticView,
+		ObjectStruct: sdk.SemanticView{},
+	},
 }
 
 func GetSdkObjectDetails() []genhelpers.SdkObjectDetails {

pkg/acceptance/bettertestspoc/assert/objectassert/semantic_view_describe_snowflake_ext.go

@@ -0,0 +1,81 @@
+package objectassert
+
+import (
+	"fmt"
+	"slices"
+	"testing"
+
+	"github.com/Snowflake-Labs/terraform-provider-snowflake/pkg/acceptance/bettertestspoc/assert"
+	"github.com/Snowflake-Labs/terraform-provider-snowflake/pkg/acceptance/helpers"
+	"github.com/Snowflake-Labs/terraform-provider-snowflake/pkg/sdk"
+)
+
+type SemanticViewDetailsCollection struct {
+	Details []sdk.SemanticViewDetails
+}
+type SemanticViewDetailsAssert struct {
+	*assert.SnowflakeObjectAssert[SemanticViewDetailsCollection, sdk.SchemaObjectIdentifier]
+}
+
+func SemanticViewDetails(t *testing.T, id sdk.SchemaObjectIdentifier) *SemanticViewDetailsAssert {
+	t.Helper()
+	return &SemanticViewDetailsAssert{
+		assert.NewSnowflakeObjectAssertWithTestClientObjectProvider(sdk.ObjectTypeSemanticView, id, func(testClient *helpers.TestClient) assert.ObjectProvider[SemanticViewDetailsCollection, sdk.SchemaObjectIdentifier] {
+			return func(t *testing.T, id sdk.SchemaObjectIdentifier) (*SemanticViewDetailsCollection, error) {
+				details, err := testClient.SemanticView.Describe(t, id)
+				if err != nil {
+					return nil, err
+				}
+				return &SemanticViewDetailsCollection{Details: details}, nil
+			}
+		}),
+	}
+}
+
+func (s *SemanticViewDetailsAssert) HasDetailsCount(expected int) *SemanticViewDetailsAssert {
+	s.AddAssertion(func(t *testing.T, o *SemanticViewDetailsCollection) error {
+		t.Helper()
+		if len(o.Details) != expected {
+			return fmt.Errorf("expected %d semantic view details; got: %d", expected, len(o.Details))
+		}
+		return nil
+	})
+	return s
+}
+
+func (s *SemanticViewDetailsAssert) ContainsDetail(expected sdk.SemanticViewDetails) *SemanticViewDetailsAssert {
+	s.AddAssertion(func(t *testing.T, o *SemanticViewDetailsCollection) error {
+		t.Helper()
+		found := slices.ContainsFunc(o.Details, func(detail sdk.SemanticViewDetails) bool {
+			return detail.ObjectKind == expected.ObjectKind &&
+				detail.ObjectName == expected.ObjectName &&
+				detail.Property == expected.Property &&
+				detail.PropertyValue == expected.PropertyValue
+		})
+		if !found {
+			return fmt.Errorf("expected semantic view to contain a detail row matching %v", expected)
+		}
+		return nil
+	})
+	return s
+}
+
+func NewSemanticViewDetails(
+	ObjectKind string,
+	ObjectName string,
+	ParentEntity *string,
+	Property string,
+	PropertyValue string,
+) sdk.SemanticViewDetails {
+	details := sdk.SemanticViewDetails{
+		ObjectKind:    ObjectKind,
+		ObjectName:    ObjectName,
+		Property:      Property,
+		PropertyValue: PropertyValue,
+	}
+	if ParentEntity != nil {
+		details.ParentEntity = ParentEntity
+	}
+
+	return details
+}

pkg/acceptance/bettertestspoc/assert/objectassert/semantic_view_snowflake_ext.go

@@ -0,0 +1,31 @@
+package objectassert
+
+import (
+	"fmt"
+	"testing"
+	"time"
+
+	"github.com/Snowflake-Labs/terraform-provider-snowflake/pkg/sdk"
+)
+
+func (s *SemanticViewAssert) HasCreatedOnNotEmpty() *SemanticViewAssert {
+	s.AddAssertion(func(t *testing.T, o *sdk.SemanticView) error {
+		t.Helper()
+		if o.CreatedOn == (time.Time{}) {
+			return fmt.Errorf("expected created_on to be not empty")
+		}
+		return nil
+	})
+	return s
+}
+
+func (s *SemanticViewAssert) HasNoComment() *SemanticViewAssert {
+	s.AddAssertion(func(t *testing.T, o *sdk.SemanticView) error {
+		t.Helper()
+		if o.Comment != nil {
+			return fmt.Errorf("expected comment to be empty")
+		}
+		return nil
+	})
+	return s
+}

pkg/acceptance/bettertestspoc/assert/objectassert/semantic_view_snowflake_gen.go

@@ -0,0 +1,68 @@
+package helpers
+
+import (
+	"context"
+	"testing"
+
+	"github.com/Snowflake-Labs/terraform-provider-snowflake/pkg/sdk"
+	"github.com/stretchr/testify/require"
+)
+
+type SemanticViewClient struct {
+	context *TestClientContext
+	ids     *IdsGenerator
+}
+
+func NewSemanticViewClient(context *TestClientContext, idsGenerator *IdsGenerator) *SemanticViewClient {
+	return &SemanticViewClient{
+		context: context,
+		ids:     idsGenerator,
+	}
+}
+
+func (c *SemanticViewClient) client() sdk.SemanticViews {
+	return c.context.client.SemanticViews
+}
+
+func (c *SemanticViewClient) Create(t *testing.T) (*sdk.SemanticView, func()) {
+	t.Helper()
+	return c.CreateWithId(t, c.ids.RandomSchemaObjectIdentifier())
+}
+
+func (c *SemanticViewClient) CreateWithId(t *testing.T, id sdk.SchemaObjectIdentifier) (*sdk.SemanticView, func()) {
+	t.Helper()
+	return c.CreateWithRequest(t, sdk.NewCreateSemanticViewRequest(id, []sdk.LogicalTableRequest{}))
+}
+
+func (c *SemanticViewClient) CreateWithRequest(t *testing.T, req *sdk.CreateSemanticViewRequest) (*sdk.SemanticView, func()) {
+	t.Helper()
+	ctx := context.Background()
+
+	err := c.client().Create(ctx, req)
+	require.NoError(t, err)
+	semanticView, err := c.client().ShowByID(ctx, req.GetName())
+	require.NoError(t, err)
+	return semanticView, c.DropFunc(t, req.GetName())
+}
+
+func (c *SemanticViewClient) DropFunc(t *testing.T, id sdk.SchemaObjectIdentifier) func() {
+	t.Helper()
+	ctx := context.Background()
+
+	return func() {
+		err := c.client().Drop(ctx, sdk.NewDropSemanticViewRequest(id).WithIfExists(true))
+		require.NoError(t, err)
+	}
+}
+
+func (c *SemanticViewClient) Show(t *testing.T, id sdk.SchemaObjectIdentifier) (*sdk.SemanticView, error) {
+	t.Helper()
+	ctx := context.Background()
+	return c.client().ShowByID(ctx, id)
+}
+
+func (c *SemanticViewClient) Describe(t *testing.T, id sdk.SchemaObjectIdentifier) ([]sdk.SemanticViewDetails, error) {
+	t.Helper()
+	ctx := context.Background()
+	return c.client().Describe(ctx, id)
+}

pkg/acceptance/helpers/semantic_view_client.go

@@ -70,6 +70,7 @@ type TestClient struct {
 	Sequence                     *SequenceClient
 	SessionPolicy                *SessionPolicyClient
 	Share                        *ShareClient
+	SemanticView                 *SemanticViewClient
 	Snapshot                     *SnapshotClient
 	Stage                        *StageClient
 	StorageIntegration           *StorageIntegrationClient
@@ -150,6 +151,7 @@ func NewTestClient(c *sdk.Client, database string, schema string, warehouse stri
 		Schema:                       NewSchemaClient(context, idsGenerator),
 		Secret:                       NewSecretClient(context, idsGenerator),
 		SecurityIntegration:          NewSecurityIntegrationClient(context, idsGenerator),
+		SemanticView:                 NewSemanticViewClient(context, idsGenerator),
 		Snapshot:                     NewSnapshotClient(context, idsGenerator),
 		Service:                      NewServiceClient(context, idsGenerator),
 		Sequence:                     NewSequenceClient(context, idsGenerator),

pkg/acceptance/helpers/test_client.go

@@ -27,14 +27,14 @@ var semanticView = g.PlainStruct("SemanticView").
 var semanticViewDetailsDbRow = g.DbStruct("semanticViewDetailsRow").
 	Text("object_kind").
 	Text("object_name").
-	Text("parent_entity").
+	OptionalText("parent_entity").
 	Text("property").
 	Text("property_value")
 
 var semanticViewDetails = g.PlainStruct("SemanticViewDetails").
 	Text("ObjectKind").
 	Text("ObjectName").
-	Text("ParentEntity").
+	OptionalText("ParentEntity").
 	Text("Property").
 	Text("PropertyValue")
 

pkg/sdk/semantic_view_def.go

@@ -0,0 +1,5 @@
+package sdk
+
+func (s *CreateSemanticViewRequest) GetName() SchemaObjectIdentifier {
+	return s.name
+}

pkg/sdk/semantic_view_ext.go

@@ -146,17 +146,17 @@ type DescribeSemanticViewOptions struct {
 }
 
 type semanticViewDetailsRow struct {
-	ObjectKind    string `db:"object_kind"`
-	ObjectName    string `db:"object_name"`
-	ParentEntity  string `db:"parent_entity"`
-	Property      string `db:"property"`
-	PropertyValue string `db:"property_value"`
+	ObjectKind    string         `db:"object_kind"`
+	ObjectName    string         `db:"object_name"`
+	ParentEntity  sql.NullString `db:"parent_entity"`
+	Property      string         `db:"property"`
+	PropertyValue string         `db:"property_value"`
 }
 
 type SemanticViewDetails struct {
 	ObjectKind    string
 	ObjectName    string
-	ParentEntity  string
+	ParentEntity  *string
 	Property      string
 	PropertyValue string
 }