feat: add semantic view resource - 1 (#4029)

Add a basic semantic view resource.
- Add a schema for the required fields.
- Do not enable the resource in the prod provider yet, as we expect a
few more PRs before this resource is usable, and we don't want to block
the releases.
Do not enable the resource in the test provider yet, as it can't be
created in its current form. It requires either the metrics or
dimensions block, which will be implemented next.
- Fix a typo in the Makefile.

## TODO
- Add the other supported fields & add this resource to the test
provider.
- Handle external changes.
- Handle object renaming.
- Handle copy grants.
- Write more acceptance tests.
- Provide examples.
- Add an entry to the migration guide.
- Add a data source.
- Extract common code, especially for block handling.

---------

Co-authored-by: shreyas <[email protected]>
Co-authored-by: Jakub Michalak <[email protected]>
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>

Author: 4 people

Makefile

@@ -200,7 +200,7 @@ generate-all-config-model-builders: generate-resource-model-builders generate-da
 generate-all-config-model-builders-check: clean-all-config-model-builders generate-all-config-model-builders ## check that generated config model builders are up-to-date
 	git diff --exit-code -- pkg/acceptance/bettertestspoc/config/model
 	git diff --exit-code -- pkg/acceptance/bettertestspoc/config/datasourcemodel
-	git diff --exit-code -- pkg/acceptance/bettertestspoc/config/providelmodel
+	git diff --exit-code -- pkg/acceptance/bettertestspoc/config/providermodel
 
 clean-all-assertions-and-config-models: clean-snowflake-object-assertions clean-snowflake-object-parameters-assertions clean-resource-assertions clean-resource-parameters-assertions clean-resource-show-output-assertions clean-resource-model-builders clean-provider-model-builders clean-datasource-model-builders ## clean all generated assertions and config models
 

pkg/acceptance/bettertestspoc/assert/objectassert/semantic_view_snowflake_gen.go

@@ -206,6 +206,10 @@ var allResourceSchemaDefs = []ResourceSchemaDef{
 		name:   "SecretWithGenericString",
 		schema: resources.SecretWithGenericString().Schema,
 	},
+	{
+		name:   "SemanticView",
+		schema: resources.SemanticView().Schema,
+	},
 	{
 		name:   "Service",
 		schema: resources.Service().Schema,

pkg/acceptance/bettertestspoc/assert/resourceassert/gen/resource_schema_def.go

@@ -0,0 +1,10 @@
+package resourceshowoutputassert
+
+import (
+	"github.com/Snowflake-Labs/terraform-provider-snowflake/pkg/acceptance/bettertestspoc/assert"
+)
+
+func (c *SemanticViewShowOutputAssert) HasCreatedOnNotEmpty() *SemanticViewShowOutputAssert {
+	c.AddAssertion(assert.ResourceShowOutputValuePresent("created_on"))
+	return c
+}

pkg/acceptance/bettertestspoc/assert/resourceassert/semantic_view_resource_gen.go

@@ -0,0 +1,82 @@
+package model
+
+import (
+	"github.com/Snowflake-Labs/terraform-provider-snowflake/pkg/sdk"
+	tfconfig "github.com/hashicorp/terraform-plugin-testing/config"
+)
+
+func (s *SemanticViewModel) WithTables(tables []sdk.LogicalTable) *SemanticViewModel {
+	maps := make([]tfconfig.Variable, len(tables))
+	for i, v := range tables {
+		m := map[string]tfconfig.Variable{
+			"table_name": tfconfig.StringVariable(v.TableName.FullyQualifiedName()),
+		}
+		if v.Comment != nil {
+			m["comment"] = tfconfig.StringVariable(*v.Comment)
+		}
+		logicalTableAlias := v.GetLogicalTableAlias()
+		if logicalTableAlias != nil {
+			m["table_alias"] = tfconfig.StringVariable(logicalTableAlias.LogicalTableAlias)
+		}
+		primaryKeys := v.GetPrimaryKeys()
+		if primaryKeys != nil {
+			keys := make([]tfconfig.Variable, len(primaryKeys.PrimaryKey))
+			for j, key := range primaryKeys.PrimaryKey {
+				keys[j] = tfconfig.StringVariable(key.Name)
+			}
+			m["primary_key"] = tfconfig.ListVariable(keys...)
+		}
+		uniqueKeys := v.GetUniqueKeys()
+		if uniqueKeys != nil {
+			keys := make([]tfconfig.Variable, len(uniqueKeys))
+			for j, key := range uniqueKeys {
+				uniKeys := make([]tfconfig.Variable, len(key.Unique))
+				for k, uniKey := range key.Unique {
+					uniKeys[k] = tfconfig.StringVariable(uniKey.Name)
+				}
+				keys[j] = tfconfig.ObjectVariable(map[string]tfconfig.Variable{
+					"values": tfconfig.ListVariable(uniKeys...),
+				})
+			}
+			m["unique"] = tfconfig.ListVariable(keys...)
+		}
+		synonyms := v.GetSynonyms()
+		if synonyms != nil {
+			syns := make([]tfconfig.Variable, len(synonyms.WithSynonyms))
+			for j, synonym := range synonyms.WithSynonyms {
+				syns[j] = tfconfig.StringVariable(synonym.Synonym)
+			}
+			m["synonym"] = tfconfig.SetVariable(syns...)
+		}
+		maps[i] = tfconfig.ObjectVariable(m)
+	}
+	s.Tables = tfconfig.ListVariable(maps...)
+	return s
+}
+
+func LogicalTableWithProps(
+	alias string,
+	tableName sdk.SchemaObjectIdentifier,
+	primaryKeys []sdk.SemanticViewColumn,
+	uniqueKeys [][]sdk.SemanticViewColumn,
+	synonyms []sdk.Synonym,
+	comment string,
+) *sdk.LogicalTable {
+	table := &sdk.LogicalTable{
+		TableName: tableName,
+		Comment:   &comment,
+	}
+	if alias != "" {
+		table.SetLogicalTableAlias(alias)
+	}
+	if primaryKeys != nil {
+		table.SetPrimaryKeys(primaryKeys)
+	}
+	if uniqueKeys != nil {
+		table.SetUniqueKeys(uniqueKeys)
+	}
+	if synonyms != nil {
+		table.SetSynonyms(synonyms)
+	}
+	return table
+}