chore: Fix future grant tests #4100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-jmichalak
force-pushed
the
fix-future-grant-tests
branch
from
356a92c to
254b196
Compare
|
Integration tests cancelled for 356a92cfadd2b208ce7aae2efa4e7f990ff21950 |
|
Account-level tests cancelled for 356a92cfadd2b208ce7aae2efa4e7f990ff21950 |
|
Integration tests cancelled for 254b196ceade9a586150ceeb8fafab5a4f2da244 |
|
Account-level tests cancelled for 254b196ceade9a586150ceeb8fafab5a4f2da244 |
| PreConfig: func() { SetV097CompatibleConfigPathEnv(t) }, | ||
| ExternalProviders: ExternalProviderWithExactVersion("0.95.0"), | ||
| Config: grantPrivilegesToAccountRoleOnFutureInDatabaseConfig(accountRoleName, []string{"USAGE"}, sdk.PluralObjectTypeModels, databaseName), | ||
| // Previously, we expected a non-empty plan, because Snowflake returned MODULE instead of MODEL in SHOW FUTURE GRANTS. |
Member
There was a problem hiding this comment.
Now this step is not that useful (same in other test). I'm wondering if we need it since the behavior in Snowflake changed 🤔
sfc-gh-jcieslak
approved these changes
Oct 16, 2025
sfc-gh-asawicki
approved these changes
Oct 16, 2025
sfc-gh-jmichalak
pushed a commit
that referenced
this pull request
Oct 17, 2025
🤖 I have created a release *beep* *boop* --- ## [2.9.0](v2.8.0...v2.9.0) (2025-10-16) ### 🎉 **What's new:** * Add new Oauth authorization code flow ([#4069](#4069)) ([4f1bb1e](4f1bb1e)) * Add new Oauth client credentials flow ([#4065](#4065)) ([4402ce3](4402ce3)) * add semantic view resource - 2 ([#4051](#4051)) ([b3a87ad](b3a87ad)) * add semantic view resource - 3 ([#4061](#4061)) ([a8695c3](a8695c3)) ### 🔧 **Misc** * Add a new protected role ([#4073](#4073)) ([02d9393](02d9393)) * Add new tests command ([#4077](#4077)) ([63d153b](63d153b)) * Add the note about terraform providers command to the namespace migration guides ([#4085](#4085)) ([11411aa](11411aa)) * Fix a typo in the roadmap ([#4095](#4095)) ([00162a0](00162a0)) * Fix future grant tests ([#4100](#4100)) ([a4c03fe](a4c03fe)) * Fix tests after new Snowflake release ([#4098](#4098)) ([75a385f](75a385f)) * Introduce a new build tag for tests ([#4054](#4054)) ([a019d82](a019d82)) * Passthrough environment variables in docker compose ([#4097](#4097)) ([7c58fd1](7c58fd1)) * Use a custom role instead of PUBLIC in OAuth with client credentials test ([#4070](#4070)) ([33d7c61](33d7c61)) ### 🐛 **Bug fixes:** * Fix token authenticator for the token field ([#4081](#4081)) ([886258e](886258e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: terraform-provider-release[bot] <205196624+terraform-provider-release[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust the assertions due to recent changes in Snowflake. Previously,
MODULEwas returned instead ofMODEL. This behavior is now fixed in Snowflake.