Merge pull request #2084 from half-duplex/fix-booleanattr-default

config: fix BooleanAttribute default=True

Author: dgw

sopel/config/types.py

@@ -404,9 +404,6 @@ def parse(self, value):
             ]
         return bool(value)
 
-    def _parse(self, value, settings, section):
-        return self.parse(value)
-
     def __set__(self, instance, value):
         if value is None:
             instance._parser.remove_option(instance._section_name, self.name)

test/test_config.py

@@ -72,6 +72,8 @@ class FakeConfigSection(types.StaticSection):
     valattr = types.ValidatedAttribute('valattr')
     listattr = types.ListAttribute('listattr')
     choiceattr = types.ChoiceAttribute('choiceattr', ['spam', 'egg', 'bacon'])
+    booleanattr = types.BooleanAttribute('booleanattr')
+    booleanattr_true = types.BooleanAttribute('booleanattr', default=True)
     af_fileattr = types.FilenameAttribute('af_fileattr', relative=False, directory=False)
     ad_fileattr = types.FilenameAttribute('ad_fileattr', relative=False, directory=True)
     rf_fileattr = types.FilenameAttribute('rf_fileattr', relative=True, directory=False)
@@ -204,6 +206,11 @@ def test_choiceattribute_when_valid(fakeconfig):
     assert fakeconfig.fake.choiceattr == 'bacon'
 
 
+def test_booleanattribute_default(fakeconfig):
+    assert fakeconfig.fake.booleanattr is False
+    assert fakeconfig.fake.booleanattr_true is True
+
+
 def test_fileattribute_valid_absolute_file_path(fakeconfig):
     testfile = os.path.join(fakeconfig.core.homedir, 'test.tmp')
     fakeconfig.fake.af_fileattr = testfile