Skip to content

Commit 86cbbe4

Browse files
authored
Merge pull request #2123 from sopel-irc/conftest-deadsnakes
conftest: remove hacks/shims for running tests on Python 3.3
2 parents 8f38990 + eebef21 commit 86cbbe4

File tree

1 file changed

+1
-12
lines changed

1 file changed

+1
-12
lines changed

conftest.py

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,7 @@ def pytest_addoption(parser):
1111

1212

1313
def pytest_collection_modifyitems(config, items):
14-
# first, make sure things run in order
15-
# needed to mitigate some weird quirk of vcrpy on Python 3.3, no idea why
16-
items.sort(key=lambda item: (item.fspath or '') + '::' + item.name)
17-
18-
# rest of this is handling for "offline mode"
14+
# handle running tests in "offline mode"
1915
if not config.getoption('--offline'):
2016
# nothing to skip
2117
return
@@ -41,10 +37,3 @@ def vcr_cassette_dir(request):
4137
# We know it's part of Sopel...
4238
parts = parts[1:]
4339
return os.path.join('test', 'vcr', *parts)
44-
45-
46-
@pytest.fixture
47-
def vcr_cassette_path(request, vcr_cassette_name):
48-
# pytest-vcr 0.3.0 looks for this fixture name
49-
# remove when killing off Python 3.3 support
50-
return os.path.join(vcr_cassette_dir(request), vcr_cassette_name)

0 commit comments

Comments
 (0)