Skip to content

Commit e25a4b1

Browse files
committed
test: replace nicks by Monty Python references
As noted by dgw, it's better to replace Sopel's owner/dev/users nicks by more neutral references to Monty Python characters and actors. Is that a dead parrot?
1 parent ec0388b commit e25a4b1

File tree

1 file changed

+31
-31
lines changed

1 file changed

+31
-31
lines changed

test/test_db.py

Lines changed: 31 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424

2525
TMP_CONFIG = """
2626
[core]
27-
owner = Embolalia
27+
owner = Pepperpots
2828
db_filename = {db_filename}
2929
"""
3030

@@ -57,15 +57,15 @@ def test_execute(db: SopelDB):
5757

5858
def test_connect(db: SopelDB):
5959
"""Test it's possible to get a raw connection and to use it properly."""
60-
nick_id = db.get_nick_id('Exirel', create=True)
60+
nick_id = db.get_nick_id('MrEricPraline', create=True)
6161
connection = db.connect()
6262

6363
try:
6464
cursor_obj = connection.cursor()
6565
cursor_obj.execute("SELECT nick_id, canonical, slug FROM nicknames")
6666
results = cursor_obj.fetchall()
6767
cursor_obj.close()
68-
assert results == [(nick_id, 'Exirel', 'exirel')]
68+
assert results == [(nick_id, 'MrEricPraline', 'mrericpraline')]
6969
finally:
7070
connection.close()
7171

@@ -80,7 +80,7 @@ def test_get_uri(db: SopelDB, tmpconfig):
8080

8181
def test_get_nick_id(db: SopelDB):
8282
"""Test get_nick_id does not create NickID by default."""
83-
nick = Identifier('Exirel')
83+
nick = Identifier('MrEricPraline')
8484

8585
# Attempt to get nick ID: it is not created by default
8686
with pytest.raises(ValueError):
@@ -94,17 +94,17 @@ def test_get_nick_id(db: SopelDB):
9494
nickname = session.execute(
9595
select(Nicknames).where(Nicknames.nick_id == nick_id)
9696
).scalar_one() # will raise if not one and exactly one
97-
assert nickname.canonical == 'Exirel'
97+
assert nickname.canonical == 'MrEricPraline'
9898
assert nickname.slug == nick.lower()
9999

100100

101101
@pytest.mark.parametrize('name, slug, variant', (
102102
# Check case insensitive with ASCII only
103-
('Embolalia', 'embolalia', 'eMBOLALIA'),
103+
('MrEricPraline', 'mrericpraline', 'mRErICPraLINE'),
104104
# Ensures case conversion is handled properly
105105
('[][]', '{}{}', '[}{]'),
106106
# Unicode, just in case
107-
('EmbölaliÅ', 'embölaliÅ', 'EMBöLALIÅ'),
107+
('MrÉrïcPrâliné', 'mrÉrïcprâliné', 'MRÉRïCPRâLINé'),
108108
))
109109
def test_get_nick_id_casemapping(db: SopelDB, name, slug, variant):
110110
"""Test get_nick_id is case-insensitive through an Identifier."""
@@ -181,8 +181,8 @@ def test_get_nick_id_migration(db: SopelDB):
181181

182182

183183
def test_alias_nick(db: SopelDB):
184-
nick = 'Embolalia'
185-
aliases = ['EmbölaliÅ', 'Embo`work', 'Embo']
184+
nick = 'MrEricPraline'
185+
aliases = ['MrÉrïcPrâliné', 'John`Cleese', 'DeadParrot']
186186

187187
nick_id = db.get_nick_id(nick, create=True)
188188
for alias in aliases:
@@ -207,34 +207,34 @@ def test_alias_nick(db: SopelDB):
207207
['structured', 'value'],
208208
))
209209
def test_set_nick_value(db: SopelDB, value):
210-
nick = 'TestNick'
210+
nick = 'Pepperpots'
211211
db.set_nick_value(nick, 'testkey', value)
212212
assert db.get_nick_value(nick, 'testkey') == value, (
213213
'The value retrieved must be exactly what was stored.')
214214

215215

216216
def test_set_nick_value_update(db: SopelDB):
217217
"""Test set_nick_value can update an existing value."""
218-
db.set_nick_value('TestNick', 'testkey', 'first-value')
219-
db.set_nick_value('TestNick', 'otherkey', 'other-value')
220-
db.set_nick_value('OtherNick', 'testkey', 'other-nick-value')
218+
db.set_nick_value('Pepperpots', 'testkey', 'first-value')
219+
db.set_nick_value('Pepperpots', 'otherkey', 'other-value')
220+
db.set_nick_value('Vikings', 'testkey', 'other-nick-value')
221221

222222
# sanity check: ensure every (nick, key, value) is correct
223-
assert db.get_nick_value('TestNick', 'testkey') == 'first-value'
224-
assert db.get_nick_value('TestNick', 'otherkey') == 'other-value'
225-
assert db.get_nick_value('OtherNick', 'testkey') == 'other-nick-value'
223+
assert db.get_nick_value('Pepperpots', 'testkey') == 'first-value'
224+
assert db.get_nick_value('Pepperpots', 'otherkey') == 'other-value'
225+
assert db.get_nick_value('Vikings', 'testkey') == 'other-nick-value'
226226

227227
# update only one key
228-
db.set_nick_value('TestNick', 'testkey', 'new-value')
228+
db.set_nick_value('Pepperpots', 'testkey', 'new-value')
229229

230230
# check new value while old values are still the same
231-
assert db.get_nick_value('TestNick', 'testkey') == 'new-value'
232-
assert db.get_nick_value('TestNick', 'otherkey') == 'other-value'
233-
assert db.get_nick_value('OtherNick', 'testkey') == 'other-nick-value'
231+
assert db.get_nick_value('Pepperpots', 'testkey') == 'new-value'
232+
assert db.get_nick_value('Pepperpots', 'otherkey') == 'other-value'
233+
assert db.get_nick_value('Vikings', 'testkey') == 'other-nick-value'
234234

235235

236236
def test_delete_nick_value(db: SopelDB):
237-
nick = 'TestUser'
237+
nick = 'TerryGilliam'
238238
db.set_nick_value(nick, 'testkey', 'test-value')
239239

240240
# sanity check
@@ -248,7 +248,7 @@ def test_delete_nick_value(db: SopelDB):
248248

249249
def test_delete_nick_value_none(db: SopelDB):
250250
"""Test method doesn't raise an error when there is nothing to delete."""
251-
nick = 'TestUser'
251+
nick = 'TerryGilliam'
252252

253253
# this user doesn't even exist
254254
db.delete_nick_value(nick, 'testkey')
@@ -275,7 +275,7 @@ def test_delete_nick_value_none(db: SopelDB):
275275
['structured', 'value'],
276276
))
277277
def test_get_nick_value(db: SopelDB, value):
278-
nick = 'TestUser'
278+
nick = 'TerryGilliam'
279279
nick_id = db.get_nick_id(nick, create=True)
280280

281281
with db.session() as session:
@@ -290,12 +290,12 @@ def test_get_nick_value(db: SopelDB, value):
290290
assert db.get_nick_value(nick, 'testkey') == value
291291
assert db.get_nick_value(nick, 'otherkey') is None
292292
assert db.get_nick_value('NotTestUser', 'testkey') is None, (
293-
'This key must be defined for TestUser only.')
293+
'This key must be defined for TerryGilliam only.')
294294

295295

296296
def test_get_nick_value_default(db: SopelDB):
297-
assert db.get_nick_value("TestUser", "nokey") is None
298-
assert db.get_nick_value("TestUser", "nokey", "default") == "default"
297+
assert db.get_nick_value("TerryGilliam", "nokey") is None
298+
assert db.get_nick_value("TerryGilliam", "nokey", "default") == "default"
299299

300300

301301
def test_unalias_nick(db: SopelDB):
@@ -336,20 +336,20 @@ def test_unalias_nick(db: SopelDB):
336336

337337
def test_unalias_nick_one_or_none(db: SopelDB):
338338
# this will create the first version of the nick
339-
db.get_nick_id('Exirel', create=True)
339+
db.get_nick_id('MrEricPraline', create=True)
340340

341341
# assert you can't unalias a unique nick
342342
with pytest.raises(ValueError):
343-
db.unalias_nick('Exirel')
343+
db.unalias_nick('MrEricPraline')
344344

345345
# and you can't either with a non-existing nick
346346
with pytest.raises(ValueError):
347-
db.unalias_nick('xnaas')
347+
db.unalias_nick('gumbys')
348348

349349

350350
def test_forget_nick_group(db: SopelDB):
351351
session = db.ssession()
352-
aliases = ['Embolalia', 'Embo']
352+
aliases = ['MrEricPraline', 'Praline']
353353
nick_id = 42
354354
for alias in aliases:
355355
nn = Nicknames(nick_id=nick_id, slug=Identifier(alias).lower(), canonical=alias)
@@ -374,7 +374,7 @@ def test_forget_nick_group(db: SopelDB):
374374

375375
def test_merge_nick_groups(db: SopelDB):
376376
session = db.ssession()
377-
aliases = ['Embolalia', 'Embo']
377+
aliases = ['MrEricPraline', 'Praline']
378378
for nick_id, alias in enumerate(aliases):
379379
nn = Nicknames(nick_id=nick_id, slug=Identifier(alias).lower(), canonical=alias)
380380
session.add(nn)

0 commit comments

Comments
 (0)