Skip to content

Commit 564ac17

Browse files
committed
release v1.12.4
1 parent 4d5754b commit 564ac17

File tree

2 files changed

+10
-24
lines changed

2 files changed

+10
-24
lines changed

CHANGELOG.md

Lines changed: 9 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -2,49 +2,35 @@
22

33
Nokogiri follows [Semantic Versioning](https://semver.org/), please see the [README.md](README.md) for details.
44

5-
---
6-
7-
## 1.12.4 / unreleased
5+
## 1.12.4 / 2021-08-29
86

97
### Notable fix: Namespace inheritance
108

11-
Namespace behavior when reparenting nodes has historically been poorly specified and the behavior
12-
diverged between CRuby and JRuby. As a result, making this behavior consistent in v1.12.0 introduced
13-
a breaking change.
9+
Namespace behavior when reparenting nodes has historically been poorly specified and the behavior diverged between CRuby and JRuby. As a result, making this behavior consistent in v1.12.0 introduced a breaking change.
1410

15-
This patch release reverts the Builder behavior present in v1.12.0..v1.12.3 but keeps the Document
16-
behavior. This release also introduces a Document attribute to allow affected users to easily change
17-
this behavior for their legacy code without invasive changes.
11+
This patch release reverts the Builder behavior present in v1.12.0..v1.12.3 but keeps the Document behavior. This release also introduces a Document attribute to allow affected users to easily change this behavior for their legacy code without invasive changes.
1812

1913

2014
#### Compensating Feature in XML::Document
2115

22-
This release of Nokogiri introduces a new `Document` boolean attribute, `namespace_inheritance`,
23-
which controls whether children should inherit a namespace when they are reparented.
24-
`Nokogiri::XML:Document` defaults this attribute to `false` meaning "do not inherit," thereby making
25-
explicit the behavior change introduced in v1.12.0.
16+
This release of Nokogiri introduces a new `Document` boolean attribute, `namespace_inheritance`, which controls whether children should inherit a namespace when they are reparented. `Nokogiri::XML:Document` defaults this attribute to `false` meaning "do not inherit," thereby making explicit the behavior change introduced in v1.12.0.
2617

27-
CRuby users who desire the pre-v1.12.0 behavior may set `document.namespace_inheritance = true` before
28-
reparenting nodes.
18+
CRuby users who desire the pre-v1.12.0 behavior may set `document.namespace_inheritance = true` before reparenting nodes.
2919

30-
See https://nokogiri.org/rdoc/Nokogiri/XML/Document.html#namespace_inheritance-instance_method for
31-
example usage.
20+
See https://nokogiri.org/rdoc/Nokogiri/XML/Document.html#namespace_inheritance-instance_method for example usage.
3221

3322

3423
#### Fix for XML::Builder
3524

36-
However, recognizing that we want `Builder`-created children to inherit namespaces, Builder now will
37-
set `namespace_inheritance=true` on the underlying document for both JRuby and CRuby. This means that, on CRuby, the pre-v1.12.0 behavior is restored.
25+
However, recognizing that we want `Builder`-created children to inherit namespaces, Builder now will set `namespace_inheritance=true` on the underlying document for both JRuby and CRuby. This means that, on CRuby, the pre-v1.12.0 behavior is restored.
3826

39-
Users who want to turn this behavior off may pass a keyword argument to the Builder constructor like
40-
so:
27+
Users who want to turn this behavior off may pass a keyword argument to the Builder constructor like so:
4128

4229
``` ruby
4330
Nokogiri::XML::Builder.new(namespace_inheritance: false)
4431
```
4532

46-
See https://nokogiri.org/rdoc/Nokogiri/XML/Builder.html#label-Namespace+inheritance for example
47-
usage.
33+
See https://nokogiri.org/rdoc/Nokogiri/XML/Builder.html#label-Namespace+inheritance for example usage.
4834

4935

5036
#### Downstream gem maintainers

lib/nokogiri/version/constant.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# frozen_string_literal: true
22
module Nokogiri
33
# The version of Nokogiri you are using
4-
VERSION = "1.12.3"
4+
VERSION = "1.12.4"
55
end

0 commit comments

Comments
 (0)