Convert all tests to Pest (#79)

* feat: install Pest

* refactor: FailedJobMonitorTest

* refactor: NotifiableTest

* replace test suite in Github action and `composer.json`

* wip

Author: alexmanase

.github/workflows/run-tests.yml

@@ -48,4 +48,4 @@ jobs:
                     composer update --${{ matrix.dependency-version }} --prefer-dist --no-interaction
 
             -   name: Execute tests
-                run: vendor/bin/phpunit
+                run: vendor/bin/pest

.phpunit.result.cache

@@ -0,0 +1 @@
+{"version":1,"defects":[],"times":{"\/Users\/alexandrumanase\/Documents\/repos\/laravel-failed-job-monitor\/tests\/FailedJobMonitorTest.php::it":0.004,"\/Users\/alexandrumanase\/Documents\/repos\/laravel-failed-job-monitor\/tests\/NotifiableTest.php::it":0.005}}

composer.json

@@ -26,9 +26,9 @@
         "spatie/laravel-package-tools": "^1.6"
     },
     "require-dev": {
-        "phpunit/phpunit": "^8.5|^9.5",
         "mockery/mockery": "^1.4",
-        "orchestra/testbench": "^5.0|^6.0|^7.0|^8.0"
+        "orchestra/testbench": "^5.0|^6.0|^7.0|^8.0",
+        "pestphp/pest": "^1.22"
     },
     "autoload": {
         "psr-4": {
@@ -41,7 +41,7 @@
         }
     },
     "scripts": {
-        "test": "vendor/bin/phpunit"
+        "test": "vendor/bin/pest"
     },
     "suggest": {
         "guzzlehttp/guzzle": "Allows notifications to be sent to Slack",
@@ -55,5 +55,10 @@
         }
     },
     "minimum-stability": "dev",
-    "prefer-stable": true
-}
+    "prefer-stable": true,
+    "config": {
+        "allow-plugins": {
+            "pestphp/pest-plugin": true
+        }
+    }
+}

tests/FailedJobMonitorTest.php

@@ -1,8 +1,5 @@
 <?php
 
-namespace Spatie\FailedJobMonitor\Test;
-
-use Illuminate\Foundation\Testing\DatabaseMigrations;
 use Illuminate\Queue\Events\JobFailed;
 use Illuminate\Support\Facades\Notification as NotificationFacade;
 use Spatie\FailedJobMonitor\Notifiable;
@@ -11,67 +8,49 @@
 use Spatie\FailedJobMonitor\Test\Dummy\AnotherNotification;
 use Spatie\FailedJobMonitor\Test\Dummy\Job;
 
-class FailedJobMonitorTest extends TestCase
-{
-    use DatabaseMigrations;
-
-    /** @var \Spatie\FailedJobMonitor\Test\Dummy\TestQueueManager */
-    protected $manager;
-
-    public function setUp(): void
+beforeAll(function () {
+    function fireFailedEvent()
     {
-        parent::setUp();
-
-        NotificationFacade::fake();
+        return event(new JobFailed('test', new Job(), new \Exception()));
     }
-
-    /** @test */
-    public function it_can_send_notification_when_a_job_failed()
+    function returnsFalseWhenExceptionIsEmpty($notification)
     {
-        $this->fireFailedEvent();
+        $message = $notification->getEvent()->exception->getMessage();
 
-        NotificationFacade::assertSentTo(new Notifiable(), Notification::class);
+        return !empty($message);
     }
+});
 
-    /** @test */
-    public function it_can_send_notification_when_job_failed_to_different_notifiable()
-    {
-        $this->app['config']->set('failed-job-monitor.notifiable', AnotherNotifiable::class);
+beforeEach(function () {
+    NotificationFacade::fake();
+});
 
-        $this->fireFailedEvent();
+it('can send notification when a job failed', function () {
+    fireFailedEvent();
 
-        NotificationFacade::assertSentTo(new AnotherNotifiable(), Notification::class);
-    }
+    NotificationFacade::assertSentTo(new Notifiable(), Notification::class);
+});
 
-    /** @test */
-    public function it_can_send_notification_when_job_failed_to_different_notification()
-    {
-        $this->app['config']->set('failed-job-monitor.notification', AnotherNotification::class);
+it('can send notification when job failed to different notifiable', function () {
+    config()->set('failed-job-monitor.notifiable', AnotherNotifiable::class);
 
-        $this->fireFailedEvent();
+    fireFailedEvent();
 
-        NotificationFacade::assertSentTo(new Notifiable(), AnotherNotification::class);
-    }
+    NotificationFacade::assertSentTo(new AnotherNotifiable(), Notification::class);
+});
 
-    /** @test */
-    public function it_filters_out_notifications_when_the_notificationFilter_returns_false()
-    {
-        $this->app['config']->set('failed-job-monitor.callback', [$this, 'returnsFalseWhenExceptionIsEmpty']);
+it('can send notification when job failed to different notification', function () {
+    config()->set('failed-job-monitor.notification', AnotherNotification::class);
 
-        $this->fireFailedEvent();
+    fireFailedEvent();
 
-        NotificationFacade::assertNotSentTo(new Notifiable(), AnotherNotification::class);
-    }
+    NotificationFacade::assertSentTo(new Notifiable(), AnotherNotification::class);
+});
 
-    protected function fireFailedEvent()
-    {
-        return event(new JobFailed('test', new Job(), new \Exception()));
-    }
+it('filters out notifications when the notificationFilter returns `false`', function () {
+    config()->set('failed-job-monitor.callback', 'returnsFalseWhenExceptionIsEmpty');
 
-    public function returnsFalseWhenExceptionIsEmpty($notification)
-    {
-        $message = $notification->getEvent()->exception->getMessage();
+    fireFailedEvent();
 
-        return ! empty($message);
-    }
-}
+    NotificationFacade::assertNotSentTo(new Notifiable(), AnotherNotification::class);
+});

tests/NotifiableTest.php

@@ -1,21 +1,14 @@
 <?php
 
-namespace Spatie\FailedJobMonitor\Test;
-
 use Spatie\FailedJobMonitor\Notifiable;
 
-class NotifiableTest extends TestCase
-{
-    /** @test */
-    public function it_returns_always_list_of_emails()
-    {
-        $notifiable = new Notifiable();
+it('returns always list of emails', function () {
+    $notifiable = new Notifiable();
 
-        $this->app['config']->set('failed-job-monitor.mail.to', '[email protected]');
-        $this->assertEquals(['[email protected]'], $notifiable->routeNotificationForMail());
+    config()->set('failed-job-monitor.mail.to', '[email protected]');
+    expect($notifiable->routeNotificationForMail())->toEqual(['[email protected]']);
 
-        $recipients = ['[email protected]', '[email protected]'];
-        $this->app['config']->set('failed-job-monitor.mail.to', $recipients);
-        $this->assertEquals($recipients, $notifiable->routeNotificationForMail());
-    }
-}
+    $recipients = ['[email protected]', '[email protected]'];
+    config()->set('failed-job-monitor.mail.to', $recipients);
+    expect($notifiable->routeNotificationForMail())->toEqual($recipients);
+});

tests/Pest.php

@@ -0,0 +1,3 @@
+<?php
+
+uses(Spatie\FailedJobMonitor\Test\TestCase::class)->in('.');