fix: ensure that server port env is set

atymic · atymic · commit ba10ce20421e · 2019-06-06T06:59:57.000+10:00
diff --git a/tests/Server.php b/tests/Server.php
@@ -6,6 +6,8 @@
 
 class Server
 {
+    const ENV_SERVER_PORT = 'TEST_SERVER_PORT';
+
     /** @var \GuzzleHttp\Client */
     protected $client;
 
@@ -40,6 +42,10 @@ public function setResponseBody(string $text, int $statusCode = 200)
 
     public static function boot()
     {
+        if (empty(getenv(self::ENV_SERVER_PORT))) {
+            throw new \InvalidArgumentException(sprintf('`%s` environment variable is not set', self::ENV_SERVER_PORT));
+        }
+
         if (! file_exists(__DIR__.'/server/vendor')) {
             exec('cd "'.__DIR__.'/server"; composer install');
         }
@@ -60,7 +66,7 @@ public static function boot()
 
     public static function getServerUrl(string $endPoint = ''): string
     {
-        return 'localhost:'.getenv('TEST_SERVER_PORT').'/'.$endPoint;
+        return sprintf('localhost:%s/%s', getenv('TEST_SERVER_PORT'), $endPoint);
     }
 
     public static function serverHasBooted(): bool

Original file line number	Diff line number	Diff line change
`@@ -6,6 +6,8 @@`
`6`	`6`
`7`	`7`	`class Server`
`8`	`8`	`{`
	`9`	`+ const ENV_SERVER_PORT = 'TEST_SERVER_PORT';`
	`10`	`+`
`9`	`11`	`/** @var \GuzzleHttp\Client */`
`10`	`12`	`protected $client;`
`11`	`13`
`@@ -40,6 +42,10 @@ public function setResponseBody(string $text, int $statusCode = 200)`
`40`	`42`
`41`	`43`	`public static function boot()`
`42`	`44`	`{`
	`45`	`+ if (empty(getenv(self::ENV_SERVER_PORT))) {`
	`46`	+ throw new \InvalidArgumentException(sprintf('`%s` environment variable is not set', self::ENV_SERVER_PORT));
	`47`	`+ }`
	`48`	`+`
`43`	`49`	`if (! file_exists(__DIR__.'/server/vendor')) {`
`44`	`50`	`exec('cd "'.__DIR__.'/server"; composer install');`
`45`	`51`	`}`
`@@ -60,7 +66,7 @@ public static function boot()`
`60`	`66`
`61`	`67`	`public static function getServerUrl(string $endPoint = ''): string`
`62`	`68`	`{`
`63`		`- return 'localhost:'.getenv('TEST_SERVER_PORT').'/'.$endPoint;`
	`69`	`+ return sprintf('localhost:%s/%s', getenv('TEST_SERVER_PORT'), $endPoint);`
`64`	`70`	`}`
`65`	`71`
`66`	`72`	`public static function serverHasBooted(): bool`