-
Notifications
You must be signed in to change notification settings - Fork 117
line wrap at 90 chars, instead of 120 #427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
It was a conscious decision to move from 90 chars to 120 and it's unlikely that we'll drop back to 90 again.
When configured to use this formatter, both IntelliJ and vscode should honor its 120 char line width. Is that not what you're seeing? |
I'm afraid not, the line indeed breaks at col 90, I'm using IntelliJ along with the formatter for a Java project, not using Maven or Gradle |
Given that you're not using Maven or Gradle, do you have the If you believe that the required file's in place but the formatter's not active, or the formatter's active but it's not formatting the code as expected, please share a minimal IntelliJ project that reproduces the problem and we can take a look. |
We still wrap javadoc and comments at 90 chars (see this part of the config). This was an intentional choice since we thought it would be useful to still have readable javadoc on smaller screens. I'm not totally sure that we should change it at this point, although it is a little inconsistent with the code wrapping. |
Thanks |
@philwebb is it possible to overwrite this setting in IntelliJ to align with the 120 chars? |
@andreasevers, only by forking the project I'm afraid. We're intentionally trying to limit the configuration options we support. From the README:
|
The source formatter uses 120 chars for wrapping. This aims to strike a balance between making use of available horizontal space in your IDE and avoiding unwanted additional wrapping when viewing code on GitHub and the like.
but it seems in both intellij and vscode, the line breaks at 90 chars
The text was updated successfully, but these errors were encountered: