Skip to content

Commit b604ccc

Browse files
committed
Merge pull request #16298 from yalov4uk
* pr/16298: Fix LogFile conditions to check for exposure as well
2 parents 76ca467 + c880e10 commit b604ccc

File tree

2 files changed

+11
-0
lines changed

2 files changed

+11
-0
lines changed

spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/logging/LogFileWebEndpointAutoConfiguration.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
package org.springframework.boot.actuate.autoconfigure.logging;
1818

1919
import org.springframework.boot.actuate.autoconfigure.endpoint.condition.ConditionalOnEnabledEndpoint;
20+
import org.springframework.boot.actuate.autoconfigure.endpoint.condition.ConditionalOnExposedEndpoint;
2021
import org.springframework.boot.actuate.logging.LogFileWebEndpoint;
2122
import org.springframework.boot.autoconfigure.EnableAutoConfiguration;
2223
import org.springframework.boot.autoconfigure.condition.ConditionMessage;
@@ -42,6 +43,7 @@
4243
*/
4344
@Configuration(proxyBeanMethods = false)
4445
@ConditionalOnEnabledEndpoint(endpoint = LogFileWebEndpoint.class)
46+
@ConditionalOnExposedEndpoint(endpoint = LogFileWebEndpoint.class)
4547
@EnableConfigurationProperties(LogFileWebEndpointProperties.class)
4648
public class LogFileWebEndpointAutoConfiguration {
4749

spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/logging/LogFileWebEndpointAutoConfigurationTests.java

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,15 @@ public void logFileWebEndpointCanBeDisabled() {
9292
.doesNotHaveBean(LogFileWebEndpoint.class));
9393
}
9494

95+
@Test
96+
public void logFileWebEndpointCanBeExcluded() {
97+
this.contextRunner
98+
.withPropertyValues("logging.file.name:test.log",
99+
"management.endpoints.web.exposure.exclude=logfile")
100+
.run((context) -> assertThat(context)
101+
.doesNotHaveBean(LogFileWebEndpoint.class));
102+
}
103+
95104
@Test
96105
public void logFileWebEndpointUsesConfiguredExternalFile() throws IOException {
97106
File file = this.temp.newFile();

0 commit comments

Comments
 (0)