Skip to content

Ensure nohttp checkstyle is only applied at top level #17081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wilkinsona opened this issue Jun 7, 2019 · 1 comment
Closed

Ensure nohttp checkstyle is only applied at top level #17081

wilkinsona opened this issue Jun 7, 2019 · 1 comment
Assignees
Labels
type: task A general task
Milestone

Comments

@wilkinsona
Copy link
Member

wilkinsona commented Jun 7, 2019

The sourceDirectories configuration of our Checkstyle setup mean that modules will check the entire directory tree beneath their location, including any sub-modules. In the 2.x builds this means that checking in spring-boot-build covers the entire source tree. We need to find a way to check more than just .java files, but avoid checking nested modules.

@wilkinsona wilkinsona added type: task A general task for: team-attention An issue we'd like other members of the team to review labels Jun 7, 2019
@wilkinsona wilkinsona added this to the 1.5.22 milestone Jun 7, 2019
@wilkinsona wilkinsona removed the for: team-attention An issue we'd like other members of the team to review label Jun 7, 2019
@wilkinsona wilkinsona self-assigned this Jun 7, 2019
@philwebb
Copy link
Member

philwebb commented Jun 7, 2019

I think we can flip this on its head and have the main build check all subfolders and just not inherited it in the children. I think I have it working locally but we'll need some CI updates.

@philwebb philwebb changed the title Polish Checkstyle configuration so that modules do not check their sub-modules Ensure nohttp checkstyle is only applied at top level Jun 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

No branches or pull requests

2 participants