GH-4337: Fix compilation warnings

Fixes: #4337

Fix test compile warnings: use mocks for ConsumerGroupMetadata, add serialVersionUID

Signed-off-by: Soby Chacko <soby.chacko@broadcom.com>

Author: sobychacko

spring-kafka/src/test/java/org/springframework/kafka/core/KafkaSaslHandlerClassloadingTest.java

@@ -140,7 +140,10 @@ static class TestableProducerFactory<K, V> extends DefaultKafkaProducerFactory<K
 	/**
 	 * Marker exception to exit producer creation after capturing classloader.
 	 */
+	@SuppressWarnings("serial")
 	static class TestAbortedException extends RuntimeException {
+
+		private static final long serialVersionUID = 1L;
 	}
 
 	/**

spring-kafka/src/test/java/org/springframework/kafka/listener/CommitOnAssignmentTests.java

@@ -196,7 +196,7 @@ public Consumer consumer() {
 				this.closeLatch.countDown();
 				return null;
 			}).given(consumer).close();
-			willReturn(new ConsumerGroupMetadata("")).given(consumer).groupMetadata();
+			willReturn(mock(ConsumerGroupMetadata.class)).given(consumer).groupMetadata();
 			return consumer;
 		}
 

spring-kafka/src/test/java/org/springframework/kafka/listener/DefaultAfterRollbackProcessorTests.java

@@ -79,7 +79,7 @@ void testClassifier() {
 		IllegalStateException illegalState = new IllegalStateException();
 		@SuppressWarnings("unchecked")
 		Consumer<String, String> consumer = mock(Consumer.class);
-		given(consumer.groupMetadata()).willReturn(new ConsumerGroupMetadata("foo"));
+		given(consumer.groupMetadata()).willReturn(mock(ConsumerGroupMetadata.class));
 		MessageListenerContainer container = mock(MessageListenerContainer.class);
 		given(container.getContainerProperties()).willReturn(new ContainerProperties("foo"));
 		processor.process(records, consumer, container, illegalState, true, EOSMode.V2);
@@ -130,7 +130,7 @@ void testBackOffNoBatchRecover() {
 		IllegalStateException illegalState = new IllegalStateException();
 		@SuppressWarnings("unchecked")
 		Consumer<String, String> consumer = mock(Consumer.class);
-		given(consumer.groupMetadata()).willReturn(new ConsumerGroupMetadata("foo"));
+		given(consumer.groupMetadata()).willReturn(mock(ConsumerGroupMetadata.class));
 		MessageListenerContainer container = mock(MessageListenerContainer.class);
 		given(container.isRunning()).willReturn(true);
 		processor.processBatch(consumerRecords, records, consumer, container, illegalState, false, EOSMode.V2);

spring-kafka/src/test/java/org/springframework/kafka/listener/DefaultErrorHandlerNoSeeksBatchListenerTests.java

@@ -218,7 +218,7 @@ public Consumer consumer() {
 				this.closeLatch.countDown();
 				return null;
 			}).given(consumer).close();
-			willReturn(new ConsumerGroupMetadata(CONTAINER_ID)).given(consumer).groupMetadata();
+			willReturn(mock(ConsumerGroupMetadata.class)).given(consumer).groupMetadata();
 			return consumer;
 		}
 
@@ -250,7 +250,7 @@ public Consumer consumer2() {
 						return new ConsumerRecords(Collections.emptyMap(), Map.of());
 				}
 			}).given(consumer).poll(any());
-			willReturn(new ConsumerGroupMetadata(CONTAINER_ID_2)).given(consumer).groupMetadata();
+			willReturn(mock(ConsumerGroupMetadata.class)).given(consumer).groupMetadata();
 			return consumer;
 		}
 

spring-kafka/src/test/java/org/springframework/kafka/listener/DefaultErrorHandlerSeekAfterCommitExceptionBatchListenerTests.java

@@ -200,7 +200,7 @@ public Consumer consumer() {
 				this.closeLatch.countDown();
 				return null;
 			}).given(consumer).close();
-			willReturn(new ConsumerGroupMetadata(CONTAINER_ID)).given(consumer).groupMetadata();
+			willReturn(mock(ConsumerGroupMetadata.class)).given(consumer).groupMetadata();
 			return consumer;
 		}
 

spring-kafka/src/test/java/org/springframework/kafka/listener/SeekToCurrentOnErrorBatchModeTXTests.java

@@ -236,7 +236,7 @@ public Consumer consumer() {
 				this.closeLatch.countDown();
 				return null;
 			}).given(consumer).close();
-			willReturn(new ConsumerGroupMetadata(CONTAINER_ID)).given(consumer).groupMetadata();
+			willReturn(mock(ConsumerGroupMetadata.class)).given(consumer).groupMetadata();
 			return consumer;
 		}
 

spring-kafka/src/test/java/org/springframework/kafka/listener/SeekToCurrentOnErrorRecordModeTXTests.java

@@ -237,7 +237,7 @@ public Consumer consumer() {
 				this.closeLatch.countDown();
 				return null;
 			}).given(consumer).close();
-			willReturn(new ConsumerGroupMetadata(CONTAINER_ID)).given(consumer).groupMetadata();
+			willReturn(mock(ConsumerGroupMetadata.class)).given(consumer).groupMetadata();
 			return consumer;
 		}
 

spring-kafka/src/test/java/org/springframework/kafka/listener/SubBatchPerPartitionTxRollbackTests.java

@@ -210,7 +210,7 @@ public Consumer consumer() {
 				this.closeLatch.countDown();
 				return null;
 			}).given(consumer).close();
-			willReturn(new ConsumerGroupMetadata(CONTAINER_ID)).given(consumer).groupMetadata();
+			willReturn(mock(ConsumerGroupMetadata.class)).given(consumer).groupMetadata();
 			return consumer;
 		}
 

spring-kafka/src/test/java/org/springframework/kafka/listener/SubBatchPerPartitionTxTests.java

@@ -196,7 +196,7 @@ public Consumer consumer() {
 				this.closeLatch.countDown();
 				return null;
 			}).given(consumer).close();
-			willReturn(new ConsumerGroupMetadata(CONTAINER_ID)).given(consumer).groupMetadata();
+			willReturn(mock(ConsumerGroupMetadata.class)).given(consumer).groupMetadata();
 			return consumer;
 		}
 

spring-kafka/src/test/java/org/springframework/kafka/listener/TransactionalContainerTests.java

@@ -244,7 +244,7 @@ private void testConsumeAndProduceTransactionGuts(boolean handleError, AckMode a
 		props.setAssignmentCommitOption(AssignmentCommitOption.ALWAYS);
 		props.setEosMode(eosMode);
 		props.setStopContainerWhenFenced(stopWhenFenced);
-		ConsumerGroupMetadata consumerGroupMetadata = new ConsumerGroupMetadata("group");
+		ConsumerGroupMetadata consumerGroupMetadata = mock(ConsumerGroupMetadata.class);
 		given(consumer.groupMetadata()).willReturn(consumerGroupMetadata);
 		final KafkaTemplate template = new KafkaTemplate(pf);
 		if (AckMode.MANUAL_IMMEDIATE.equals(ackMode)) {