Merge pull request #381 from rrvrs/500-fix

optimisations

Author: srbhr

apps/backend/app/schemas/pydantic/resume_preview.py

@@ -16,18 +16,18 @@ class PersonalInfo(BaseModel):
 class ExperienceItem(BaseModel):
     id: int
     title: str
-    company: str
+    company: Optional[str] = None
     location: Optional[str] = None
-    years: str
-    description: List[str]
+    years: Optional[str] = None
+    description: List[Optional[str]] = []
 
 
 class EducationItem(BaseModel):
     id: int
     institution: str
     degree: str
     years: str
-    description: str
+    description: Optional[str] = None
 
 
 class ResumePreviewerModel(BaseModel):

apps/frontend/lib/api/resume.ts

@@ -23,13 +23,32 @@ export async function improveResume(
     resumeId: string,
     jobId: string
 ): Promise<ImprovedResult> {
-    const res = await fetch(`${API_URL}/api/v1/resumes/improve`, {
-        method: 'POST',
-        headers: { 'Content-Type': 'application/json' },
-        body: JSON.stringify({ resume_id: resumeId, job_id: jobId }),
-    });
-    if (!res.ok) throw new Error(`Improve failed with status ${res.status}`);
-    const data = await res.json();
+    let response: Response;
+    try {
+        response = await fetch(`${API_URL}/api/v1/resumes/improve`, {
+            method: 'POST',
+            headers: { 'Content-Type': 'application/json' },
+            body: JSON.stringify({ resume_id: resumeId, job_id: jobId }),
+        });
+    } catch (networkError) {
+        console.error('Network error during improveResume:', networkError);
+        throw networkError;
+    }
+
+    const text = await response.text();
+    if (!response.ok) {
+        console.error('Improve failed response body:', text);
+        throw new Error(`Improve failed with status ${response.status}: ${text}`);
+    }
+
+    let data: ImprovedResult;
+    try {
+        data = JSON.parse(text) as ImprovedResult;
+    } catch (parseError) {
+        console.error('Failed to parse improveResume response:', parseError, 'Raw response:', text);
+        throw parseError;
+    }
+
     console.log('Resume improvement response:', data);
-    return data as ImprovedResult;
+    return data;
 }