release v14.6.0 (#1341)

* update stellar-base dependency and bump version to v14.6.0

* add e2e test for non-simulated SAC transfer transaction

Author: Ryang-21

.github/workflows/format.yml

@@ -23,4 +23,11 @@ jobs:
         run: yarn install --network-concurrency 1
 
       - name: Run Linter Checks
-        run: yarn fmt && (git diff-index --quiet HEAD; git diff)
+        run: |
+          yarn fmt
+          if ! git diff-index --quiet HEAD; then
+            echo "::error::Formatting issues detected. Please run 'yarn fmt' locally and commit the changes."
+            git diff --stat
+            git diff
+            exit 1
+          fi

CHANGELOG.md

@@ -6,6 +6,11 @@ A breaking change will get clearly marked in this log.
 
 ## Unreleased
 
+## [v14.6.0](https://github.com/stellar/js-stellar-sdk/compare/v14.5.0...v14.6.0)
+
+### Added
+* Upgraded underlying `@stellar/stellar-base` library to include its new features and fixes ([release notes](https://github.com/stellar/js-stellar-base/releases/tag/v14.1.0)).
+
 ## [v14.5.0](https://github.com/stellar/js-stellar-sdk/compare/v14.4.3...v14.5.0)
 
 ### Added

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@stellar/stellar-sdk",
-  "version": "14.5.0",
+  "version": "14.6.0",
   "description": "A library for working with the Stellar network, including communication with the Horizon and Soroban RPC servers.",
   "keywords": [
     "stellar"
@@ -198,7 +198,7 @@
     "webpack-cli": "^5.0.1"
   },
   "dependencies": {
-    "@stellar/stellar-base": "^14.0.4",
+    "@stellar/stellar-base": "^14.1.0",
     "axios": "^1.13.3",
     "bignumber.js": "^9.3.1",
     "commander": "^14.0.2",

test/e2e/src/non-sim-sac-transfer.test.ts

@@ -0,0 +1,277 @@
+import { expect, describe, it, beforeAll } from "vitest";
+import {
+  Asset,
+  BASE_FEE,
+  Keypair,
+  Operation,
+  TransactionBuilder,
+  rpc,
+} from "../../../lib";
+import { generateFundedKeypair, networkPassphrase, server } from "./util";
+
+const TRANSFER_AMOUNT = 1_0000000n; // 1 token with 7 decimals
+
+/**
+ * Helper to build, sign, send, and poll a transaction with a single signer.
+ */
+async function submitTx(
+  sourceKeypair: Keypair,
+  op: ReturnType<
+    | typeof Operation.changeTrust
+    | typeof Operation.payment
+    | typeof Operation.createStellarAssetContract
+  >,
+) {
+  const account = await server.getAccount(sourceKeypair.publicKey());
+  const builder = new TransactionBuilder(account, {
+    fee: BASE_FEE,
+    networkPassphrase,
+  }).setTimeout(30);
+
+  builder.addOperation(op);
+
+  const tx = builder.build();
+  if (
+    op.body().switch().name === "changeTrust" ||
+    op.body().switch().name === "payment"
+  ) {
+    // Classic operations can not be simulated, so we send them directly without simulation to ensure the test setup is complete.
+    tx.sign(sourceKeypair);
+    const classicResp = await server.sendTransaction(tx);
+    const classicResult = await server.pollTransaction(classicResp.hash, {
+      attempts: 15,
+    });
+    if (classicResult.status !== rpc.Api.GetTransactionStatus.SUCCESS) {
+      throw new Error(`Classic transaction failed: ${classicResult.status}`);
+    }
+    return classicResult;
+  }
+  const sim = await server.simulateTransaction(tx);
+  if (rpc.Api.isSimulationError(sim)) {
+    throw new Error(`Simulation failed: ${sim.error}`);
+  }
+  const assembled = rpc.assembleTransaction(tx, sim).build();
+  assembled.sign(sourceKeypair);
+
+  const resp = await server.sendTransaction(assembled);
+  const result = await server.pollTransaction(resp.hash, { attempts: 15 });
+  if (result.status !== rpc.Api.GetTransactionStatus.SUCCESS) {
+    throw new Error(`Transaction failed: ${result.status}`);
+  }
+  return result;
+}
+
+let context: {
+  sender: Keypair;
+  receiver: Keypair;
+  issuer: Keypair;
+  customAsset: Asset;
+};
+
+// These tests are to ensure that the SAC transfer operation works end-to-end on a real network,
+// and to catch any issues with the way the operation is built.
+// They are not meant to be exhaustive tests of all possible transfer scenarios,
+// but rather a sanity check that basic transfers succeed without errors.
+describe("Non-simulated SAC Transfer", () => {
+  beforeAll(async () => {
+    const sender = await generateFundedKeypair();
+    const receiver = await generateFundedKeypair();
+    const issuer = await generateFundedKeypair();
+
+    const customAsset = new Asset("TST", issuer.publicKey());
+
+    // 1. Establish trustlines for the custom asset
+    await submitTx(sender, Operation.changeTrust({ asset: customAsset }));
+    await submitTx(receiver, Operation.changeTrust({ asset: customAsset }));
+
+    // 2. Issuer mints tokens to sender and receiver
+    await submitTx(
+      issuer,
+      Operation.payment({
+        destination: sender.publicKey(),
+        asset: customAsset,
+        amount: "100",
+      }),
+    );
+    await submitTx(
+      issuer,
+      Operation.payment({
+        destination: receiver.publicKey(),
+        asset: customAsset,
+        amount: "100",
+      }),
+    );
+
+    // 3. Deploy the Stellar Asset Contract for the custom asset and native
+    await submitTx(
+      issuer,
+      Operation.createStellarAssetContract({ asset: customAsset }),
+    );
+    await submitTx(
+      issuer,
+      Operation.createStellarAssetContract({ asset: Asset.native() }),
+    );
+
+    context = { sender, receiver, issuer, customAsset };
+  });
+
+  describe("native asset transfers", () => {
+    it("should transfer native XLM between user accounts", async () => {
+      const { sender, receiver } = context;
+
+      const account = await server.getAccount(sender.publicKey());
+      const tx = new TransactionBuilder(account, {
+        fee: BASE_FEE,
+        networkPassphrase,
+      })
+        .setTimeout(30)
+        .addSacTransferOperation(
+          receiver.publicKey(),
+          Asset.native(),
+          TRANSFER_AMOUNT,
+        )
+        .build();
+
+      tx.sign(sender);
+
+      const response = await server.sendTransaction(tx);
+      expect(response.errorResult).toBeUndefined();
+
+      const result = await server.pollTransaction(response.hash, {
+        attempts: 10,
+      });
+      expect(result.status).toBe(rpc.Api.GetTransactionStatus.SUCCESS);
+    });
+
+    it("should transfer native XLM from user to contract address", async () => {
+      const { sender, customAsset } = context;
+      const contractId = customAsset.contractId(networkPassphrase);
+
+      const account = await server.getAccount(sender.publicKey());
+      const tx = new TransactionBuilder(account, {
+        fee: BASE_FEE,
+        networkPassphrase,
+      })
+        .setTimeout(30)
+        .addSacTransferOperation(contractId, Asset.native(), TRANSFER_AMOUNT)
+        .build();
+
+      tx.sign(sender);
+
+      const response = await server.sendTransaction(tx);
+      expect(response.errorResult).toBeUndefined();
+
+      const result = await server.pollTransaction(response.hash, {
+        attempts: 10,
+      });
+      expect(result.status).toBe(rpc.Api.GetTransactionStatus.SUCCESS);
+    });
+  });
+
+  describe("custom SAC token transfers", () => {
+    it("should transfer a custom SAC token between user accounts", async () => {
+      const { sender, receiver, customAsset } = context;
+
+      const account = await server.getAccount(sender.publicKey());
+      const tx = new TransactionBuilder(account, {
+        fee: BASE_FEE,
+        networkPassphrase,
+      })
+        .setTimeout(30)
+        .addSacTransferOperation(
+          receiver.publicKey(),
+          customAsset,
+          TRANSFER_AMOUNT,
+        )
+        .build();
+
+      tx.sign(sender);
+
+      const response = await server.sendTransaction(tx);
+      expect(response.errorResult).toBeUndefined();
+
+      const result = await server.pollTransaction(response.hash, {
+        attempts: 10,
+      });
+      expect(result.status).toBe(rpc.Api.GetTransactionStatus.SUCCESS);
+    });
+
+    it("should transfer a custom SAC token from user to contract address", async () => {
+      const { sender, customAsset } = context;
+      const contractId = customAsset.contractId(networkPassphrase);
+
+      const account = await server.getAccount(sender.publicKey());
+      const tx = new TransactionBuilder(account, {
+        fee: BASE_FEE,
+        networkPassphrase,
+      })
+        .setTimeout(30)
+        .addSacTransferOperation(contractId, customAsset, TRANSFER_AMOUNT)
+        .build();
+
+      tx.sign(sender);
+
+      const response = await server.sendTransaction(tx);
+      expect(response.errorResult).toBeUndefined();
+
+      const result = await server.pollTransaction(response.hash, {
+        attempts: 10,
+      });
+      expect(result.status).toBe(rpc.Api.GetTransactionStatus.SUCCESS);
+    });
+
+    it("should transfer a custom SAC token when sender is the issuer", async () => {
+      const { issuer, receiver, customAsset } = context;
+
+      const account = await server.getAccount(issuer.publicKey());
+      const tx = new TransactionBuilder(account, {
+        fee: BASE_FEE,
+        networkPassphrase,
+      })
+        .setTimeout(30)
+        .addSacTransferOperation(
+          receiver.publicKey(),
+          customAsset,
+          TRANSFER_AMOUNT,
+        )
+        .build();
+
+      tx.sign(issuer);
+
+      const response = await server.sendTransaction(tx);
+      expect(response.errorResult).toBeUndefined();
+
+      const result = await server.pollTransaction(response.hash, {
+        attempts: 10,
+      });
+      expect(result.status).toBe(rpc.Api.GetTransactionStatus.SUCCESS);
+    });
+
+    it("should transfer a custom SAC token when receiver is the issuer", async () => {
+      const { sender, issuer, customAsset } = context;
+
+      const account = await server.getAccount(sender.publicKey());
+      const tx = new TransactionBuilder(account, {
+        fee: BASE_FEE,
+        networkPassphrase,
+      })
+        .setTimeout(30)
+        .addSacTransferOperation(
+          issuer.publicKey(),
+          customAsset,
+          TRANSFER_AMOUNT,
+        )
+        .build();
+
+      tx.sign(sender);
+
+      const response = await server.sendTransaction(tx);
+      expect(response.errorResult).toBeUndefined();
+
+      const result = await server.pollTransaction(response.hash, {
+        attempts: 10,
+      });
+      expect(result.status).toBe(rpc.Api.GetTransactionStatus.SUCCESS);
+    });
+  });
+});

yarn.lock

@@ -1756,10 +1756,10 @@
   resolved "https://registry.yarnpkg.com/@stellar/js-xdr/-/js-xdr-3.1.2.tgz#db7611135cf21e989602fd72f513c3bed621bc74"
   integrity sha512-VVolPL5goVEIsvuGqDc5uiKxV03lzfWdvYg1KikvwheDmTBO68CKDji3bAZ/kppZrx5iTA8z3Ld5yuytcvhvOQ==
 
-"@stellar/stellar-base@^14.0.4":
-  version "14.0.4"
-  resolved "https://registry.yarnpkg.com/@stellar/stellar-base/-/stellar-base-14.0.4.tgz#530511679588e8440277ded071e3a46a387c9fff"
-  integrity sha512-UbNW6zbdOBXJwLAV2mMak0bIC9nw3IZVlQXkv2w2dk1jgCbJjy3oRVC943zeGE5JAm0Z9PHxrIjmkpGhayY7kw==
+"@stellar/stellar-base@^14.1.0":
+  version "14.1.0"
+  resolved "https://registry.yarnpkg.com/@stellar/stellar-base/-/stellar-base-14.1.0.tgz#5093aaabd03eb1364833fb88c26a9e20f857e7d8"
+  integrity sha512-A8kFli6QGy22SRF45IjgPAJfUNGjnI+R7g4DF5NZYVsD1kGf7B4ITyc4OPclLV9tqNI4/lXxafGEw0JEUbHixw==
   dependencies:
     "@noble/curves" "^1.9.6"
     "@stellar/js-xdr" "^3.1.2"