Skip to content

Commit 0eb918f

Browse files
committed
🚨(helm) fix helmfile lint
Latest release of helmfile is applying the change related before as a warning. Environnements must be before releases but not in the same document of repositories.
1 parent 170dbe0 commit 0eb918f

File tree

3 files changed

+11
-9
lines changed

3 files changed

+11
-9
lines changed

.github/workflows/helmfile-linter.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ jobs:
1111
helmfile-lint:
1212
runs-on: ubuntu-latest
1313
container:
14-
image: ghcr.io/helmfile/helmfile:latest
14+
image: ghcr.io/helmfile/helmfile:v0.171.0
1515
steps:
1616
-
1717
name: Checkout repository
@@ -22,9 +22,9 @@ jobs:
2222
run: |
2323
set -e
2424
HELMFILE=src/helm/helmfile.yaml
25-
environments=$(awk '/environments:/ {flag=1; next} flag && NF {print} !NF {flag=0}' "$HELMFILE" | grep -E '^[[:space:]]{2}[a-zA-Z]+' | sed 's/^[[:space:]]*//;s/:.*//')
25+
environments=$(awk 'BEGIN {in_env=0} /^environments:/ {in_env=1; next} /^---/ {in_env=0} in_env && /^ [^ ]/ {gsub(/^ /,""); gsub(/:.*$/,""); print}' "$HELMFILE")
2626
for env in $environments; do
2727
echo "################### $env lint ###################"
2828
helmfile -e $env -f $HELMFILE lint || exit 1
2929
echo -e "\n"
30-
done
30+
done

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ and this project adheres to
2727
- 🐛(backend) refactor to fix filtering on children
2828
and descendants views #695
2929
- 🐛(action) fix notify-argocd workflow #713
30+
- 🚨(helm) fix helmfile lint #736
3031

3132

3233
## [2.4.0] - 2025-03-06

src/helm/helmfile.yaml

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,13 @@
1+
environments:
2+
dev:
3+
values:
4+
- version: 2.4.0
5+
---
16
repositories:
27
- name: bitnami
38
url: registry-1.docker.io/bitnamicharts
49
oci: true
10+
---
511

612
releases:
713
- name: keycloak
@@ -88,9 +94,4 @@ releases:
8894
namespace: {{ .Namespace }}
8995
chart: ./impress
9096
values:
91-
- env.d/{{ .Environment.Name }}/values.impress.yaml.gotmpl
92-
93-
environments:
94-
dev:
95-
values:
96-
- version: 2.4.0
97+
- env.d/{{ .Environment.Name }}/values.impress.yaml.gotmpl

0 commit comments

Comments
 (0)