Keep PHP binary responses as strings for easier manipulation.

Author: jqr

modules/swagger-codegen/src/main/resources/php/ObjectSerializer.mustache

@@ -242,7 +242,7 @@ class ObjectSerializer
             }
             $deserialized = $values;
         } elseif ($class === 'ByteArray') { // byte array
-            $deserialized = unpack('C*', (string)$data);
+            $deserialized = (string)$data;
         } elseif ($class === '\DateTime') {
             $deserialized = new \DateTime($data);
         } elseif (in_array($class, array({{&primitives}}))) {

modules/swagger-codegen/src/main/resources/php/api.mustache

@@ -188,7 +188,7 @@ use \{{invokerPackage}}\ObjectSerializer;
         {{#bodyParams}}// body params
         $_tempBody = null;
         if (isset(${{paramName}})) {
-            {{^isBinary}}$_tempBody = ${{paramName}};{{/isBinary}}{{#isBinary}}$_tempBody = call_user_func_array('pack', array_merge(array('C*'), ${{paramName}}));{{/isBinary}}
+            $_tempBody = ${{paramName}};
         }{{/bodyParams}}
 
         // for model (json/xml)

samples/client/petstore/php/SwaggerClient-php/lib/Api/PetApi.php

@@ -1036,7 +1036,7 @@ public function addPetUsingByteArrayWithHttpInfo($body = null)
         // body params
         $_tempBody = null;
         if (isset($body)) {
-            $_tempBody = call_user_func_array('pack', array_merge(array('C*'), $body));
+            $_tempBody = $body;
         }
 
         // for model (json/xml)

samples/client/petstore/php/SwaggerClient-php/lib/ObjectSerializer.php

@@ -242,7 +242,7 @@ public static function deserialize($data, $class, $httpHeaders=null)
             }
             $deserialized = $values;
         } elseif ($class === 'ByteArray') { // byte array
-            $deserialized = unpack('C*', (string)$data);
+            $deserialized = (string)$data;
         } elseif ($class === '\DateTime') {
             $deserialized = new \DateTime($data);
         } elseif (in_array($class, array('integer', 'int', 'void', 'number', 'object', 'double', 'float', 'byte', 'DateTime', 'string', 'mixed', 'boolean', 'bool'))) {

samples/client/petstore/php/SwaggerClient-php/tests/PetApiTest.php

@@ -279,7 +279,7 @@ public function testAddPetUsingByteArray()
         // add a new pet (model)
         $object_serializer = new Swagger\Client\ObjectSerializer();
         $pet_json_string = json_encode($object_serializer->sanitizeForSerialization($new_pet));
-        $add_response = $pet_api->addPetUsingByteArray(unpack('C*', $pet_json_string));
+        $add_response = $pet_api->addPetUsingByteArray($pet_json_string);
         // return nothing (void)
         $this->assertSame($add_response, NULL);
         // verify added Pet
@@ -330,9 +330,9 @@ public function testGetPetByIdWithByteArray()
         // test getPetByIdWithByteArray 
         $pet_id = 10005;
         $bytes = $pet_api->petPetIdtestingByteArraytrueGet($pet_id);
-        $json = json_decode(call_user_func_array('pack', array_merge(array('C*'), $bytes )), true);
+        $json = json_decode($bytes, true);
 
-        $this->assertInternalType("array", $bytes);
+        $this->assertInternalType("string", $bytes);
 
         $this->assertSame($json['id'], $pet_id);
         // not testing name as it's tested by addPetUsingByteArray