comments

Author: syphar

src/utils/html.rs

@@ -118,6 +118,7 @@ where
                     };
 
                     let mut rewriter = HtmlRewriter::new(settings, move |chunk: &[u8]| {
+                        // this can fail only when the receiver is dropped.
                         let _ = result_sender.send(Bytes::from(chunk.to_vec()));
                     });
                     while let Some(chunk) = data_receiver.recv()? {
@@ -134,7 +135,7 @@ where
         loop {
             let n = match reader.read(&mut read_buf).await {
                 Ok(0) => {
-                    // this should get the background thread to exit
+                    // This signals the renderer thread to finalize & exit.
                     data_sender.send(None).unwrap();
                     break;
                 }
@@ -146,7 +147,7 @@ where
                 }
             };
             if let Err(err) = data_sender.send(Some(read_buf[..n].to_vec())) {
-                // reveiver was dropped?
+                // FIXME: reveiver was dropped? do we care about that?
                 yield Err(RewritingError::ContentHandlerError(err.into()));
                 break;
             }