Skip to content

v253 batch up to da2d44a3d9c4af642dabef12b8d81887b3cfbec2 #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Jun 26, 2025
Merged

v253 batch up to da2d44a3d9c4af642dabef12b8d81887b3cfbec2 #488

merged 21 commits into from
Jun 26, 2025

Conversation

bluca
Copy link
Member

@bluca bluca commented Jun 26, 2025

No description provided.

AdrianVovk and others added 21 commits June 26, 2025 12:21
@AdrianVovk @bluca
man/systemd.timer: Correct inaccuracy in man page
7707a2a 
The docs previously stated that RandomizedDelaySec is applied onto the
next scheduled time, but after 9fa326b
this is no longer the case.

I also reworded FixedRandomDelay= slightly, to make it a bit clearer

(cherry picked from commit fca20a1be69d0ffe3067e5c8676d75b5f8af1a5d)
(cherry picked from commit 0930949e64cd91e366865e104a295ddc83170fdd)
(cherry picked from commit a37d96386a3f8ded382164ad85e458e848853499)
(cherry picked from commit fe859ba)
(cherry picked from commit 47ed4d5)
@yuwata @bluca
network/link: ENODATA from reading IFLA_MASTER when an interface has …
1359ed5 
…no master

When an interface leaved from the master interface, then reading
IFLA_MASTER attribute causes ENODATA. When the interface was previously
enslaved to another interface, we need to remove reference to the
interface from the previous master interface.

This is especially important when
```
ip link set dev eth0 nomaster
```
is called.

Fixes a bug introduced by 0d411b7 (v249).
Fixes #37629.

(cherry picked from commit f44b20b7b6c6b0a089a3ec2392ac85e4772e0357)
(cherry picked from commit 2ad46c06069ad4241c94124dd5a3a73da7828048)
(cherry picked from commit c584dfb2051207af017ea1437b3d255023c902f5)
(cherry picked from commit a023d22)
(cherry picked from commit 61f69d4)
@yuwata @bluca
network/link: update state file when master ifindex is changed
1b537d5 
If master ifindex is non-zero, then the carrier state and operational
state of the interface may be the enslaved state.
As the operational state is saved in link state file, and read by
wait-online, we need to update the state file when the master ifindex is
changed.

(cherry picked from commit 7dde00ca57cf20a5d71e580d0bc6173f454095e5)
(cherry picked from commit e9655c7865d632bd05437f8ebd4264a13b8011e4)
(cherry picked from commit 018e874b84c53ef5b8c2f4835a2f9e554c5fe409)
(cherry picked from commit 2057199)
(cherry picked from commit 936aa69)
@yuwata @bluca
test-network: add test case for issue #37629
a6b2111 
(cherry picked from commit b1bed07d84d76f3ab2f11a42fefce2685dbbe685)
(cherry picked from commit a11a8221019a3c364e783052e18dcf438fa3dace)
(cherry picked from commit 8c2213cf1e2f552ccecf396531e861de4ce77d69)
(cherry picked from commit 5f7efc2)
(cherry picked from commit 6ef8df6)
@bluca
sysupdate: change status once operation has completed
91d46d5 
Otherwise after the service exits it will still show
"Installing 'foobar'" as the status, which is confusing

(cherry picked from commit 5cfc9c34f4a38cc82c233e453373d48231944d81)
(cherry picked from commit 0e502d986b724f195385ad99f7f214d8586fec7f)
(cherry picked from commit 8d7dce9a534cf14a2587145590ddea01eeb84291)
(cherry picked from commit 43e73a7)
(cherry picked from commit f82b4cc)
@bluca
test: wait for coredump to appear before parsing
e107f86 
A new core was added to the test, but the loop counter was not increased
to wait for it, so the test races against systemd-coredump's processing.

This failed at least once in debci:

8015s [   32.227813] TEST-87-AUX-UTILS-VM.sh[1038]: + coredumpctl info COREDUMP_TIMESTAMP=1679509902000000
8015s [   32.228684] TEST-87-AUX-UTILS-VM.sh[1723]: No coredumps found.

Follow-up for 0c49e0049b7665bb7769a13ef346fef92e1ad4d6

Fixes systemd/systemd#37666

(cherry picked from commit 703fbb0bba7f1a1b46342d6efedda30e51d46135)
(cherry picked from commit ccbad62c42ab8e00b824aaa22036cc5cc65ab203)
(cherry picked from commit 5ef906f002ec50fa62232a83dc974620fd6b046c)
(cherry picked from commit 12f4ba1)
(cherry picked from commit 08280df)
@MonterraByte @bluca
bootctl: fix unclosed quote in debug log
fd1ee71 
(cherry picked from commit c9e614eb256ec2591170c1b840558103dfa3d2b0)
(cherry picked from commit 4af9f5044a352fc0d67b3eb57ae09b595f724eee)
(cherry picked from commit 7ac7b91ae030b1d6ca0a5efb4a26c8c30f6da5a1)
(cherry picked from commit d1bf709)
(cherry picked from commit 64c19d4)
@mugitya03 @jinyaoguo @bluca
network: fix a potential divide-by-zero (#37705)
5501938 
In function `tc_init`, hz is parsed from the content of file
`"/proc/net/psched"` and can be 0.
In function `hierarchy_token_bucket_class_verify`, hz is directly used
as a divisor in
`htb->buffer = htb->rate / hz + htb->mtu;` without any check. This adds a check on hz before using it as a divisor.

Co-authored-by: jinyaoguo <[email protected]>
(cherry picked from commit 1a596054a0f937bfc244580f07510759a0e45657)
(cherry picked from commit e2c9fdd5c0f84eb234e122fe8fce9c4d949882cd)
(cherry picked from commit 64206ad1372a7df4c96c1fd8cd363a6032eaeadf)
(cherry picked from commit b53cf28)
(cherry picked from commit f5fdc85)
@mugitya03 @jinyaoguo @bluca
compress: prevent divide-by-zero when no data is read (#37706)
459789a 
If the first call to `loop_read()` returns 0 (no input), `total_in`
remains 0, causing `total_out/total_in` to potential divide by zero.

We add a check before logging the compression ratio to skip the
percentage calculation when total_in is zero.

Co-authored-by: jinyaoguo <[email protected]>
(cherry picked from commit 2584f745e0509472e68449bd81c60c26056d514a)
(cherry picked from commit 18a42e321d699e7f3ae46930fa070228d02774ed)
(cherry picked from commit eaffe6679b6bcf6d5ba4d468332079a9ac82da43)
(cherry picked from commit 93f677f)
(cherry picked from commit cb57cbc)
@yuwata @bluca
repart: if partition already exists, required size may not be multipl…
cd3c9af 
…e of grain size

See partition_min_size_with_padding().
Fixes #37178.

(cherry picked from commit cb109e00c45c8e92b1020e6249aac4a212e7f72d)
(cherry picked from commit 4e6d6d885d320c27deb63b8a5ae5b330c00a174c)
(cherry picked from commit ee9434f7022fdbb48a2f1466d9531da2a30c35cd)
(cherry picked from commit 8e76eab)
(cherry picked from commit 4c3fecc)
@poettering @bluca
resolved: honour SD_RESOLVED_NO_CNAME flag when processing cache
f7f20e2 
Fixes: #33300
Replaces: #35102
(cherry picked from commit 959d7f1759d67994e3bed7b9d2f23e063475a872)
(cherry picked from commit 8f1b7ec9edd4ce7d5ced86d29e659fda95dd95f3)
(cherry picked from commit b5d7d32d6575f28bc447576e1da52f8f41805c79)
(cherry picked from commit cf3d93b)
(cherry picked from commit dd2e419)
@poettering @bluca
io-util: protect against INT_MAX overflow in flush_fd()
998669f 
(cherry picked from commit 874c4beb24ade904589bf672685752727cbb791e)
(cherry picked from commit 93fc50ec2b3f505e20774dda45b37f1b594a4226)
(cherry picked from commit a332cc7f6a444e8f738476c2cc12d93ef286cf24)
(cherry picked from commit 57aaba3)
(cherry picked from commit 9341836)
@bluca
socket: downgrade not-supported logging for SO_PASSSEC
aa9f4f6 
Kernel 6.16 started returning EOPNOTSUPP when a required kconfig
is disabled. Downgrade to debug level in that case.

Fixes systemd/systemd#37783

(cherry picked from commit bb887cf22e68b6c83ff8a9c9bccda04d95ac23b3)
(cherry picked from commit 42cc4991976821d33b094a4d3787cd6b80a8fbdb)
(cherry picked from commit 1613414ac0a5a370e8754943c273f49ba37edaf3)
(cherry picked from commit b97861d)
(cherry picked from commit 17cccd3)
@yuwata @bluca
resolve: exit from loop for transactions when transactions has been r…
e9e748e 
…egenerated

Fixes #37458.

(cherry picked from commit 5814acca9aa4354d121de4bf174851f092a6b643)
(cherry picked from commit e40fbaa18e747ee213303cd0ff780d95f5c812e9)
(cherry picked from commit 579b59ac1db32ed5848474c59300419f28126117)
(cherry picked from commit ce1d728)
(cherry picked from commit e316f1e)
@bluca
fstab-generator: set mode=0755 with root=tmpfs
06d4a04 
If mode= is not set in rootflags= add mode=0755 when a tmpfs
is used on the rootfs, otherwise it will be group/world writable
as that's the default mode for tmpfs filesystems.

Follow-up for 725ad3b

(cherry picked from commit d3a57a0853de1a4a03b4ae1fbfa8bc59dc01b217)
(cherry picked from commit 0e8f13faf3fafc3679131713915a56c74403f3a3)
(cherry picked from commit 69beb94574ba41b167396fdcd651e9f59f2d8d75)
(cherry picked from commit 0fc39fe)
(cherry picked from commit e1560b3)
@gtsiam @bluca
resolved: Tweak link-local addresses relevancy
7e6216d 
We now consider link-local addresses routable when we have configured
unicast link-local dns servers. This allows creating the DNS scope, even
when the interface doesn't get a routable address.

(cherry picked from commit c60d2a626b88aec24e6f029f799b6631c1aaeee2)
(cherry picked from commit bd9a51fc67faead42dcaac819f5c432741b4a32a)
(cherry picked from commit 807e18536ad96a28d041ce57b760cfb81c980cd6)
(cherry picked from commit 1272e28)
(cherry picked from commit 81afa81)
@lnykryn @bluca
man: encourage the creation of empty machine-id instead of deleting it
6224c10 
Current text hints that machine-id in template image should be empty
if the system is read-only. But most of the bare metal systems and
regular VMs have /etc read-only at this phase of boot.

(cherry picked from commit 64fcb07199f8409a074575eda5abb69b0caab06f)
(cherry picked from commit 5f55879673b119ebc98280518a9ab5bb7f4b1c5d)
(cherry picked from commit 8ee0c2ee0ca8be0a34e9528b11e912735e8b5a33)
(cherry picked from commit 6e9eba2)
(cherry picked from commit df71727)
@bluca
homed: do not log new password when debug logs are enabled
614d015 
systemd-homed[3443]: Sending to worker:
{
  "enforcePasswordPolicy": false,
  "userName": "foobarbaz",
  "perMachine": [
    {
      "storage": "directory",
      "matchMachineId": "c1082742b92c4f7e8d30d6b17f9d3351"
    }
  ],
  "disposition": "regular",
  "lastChangeUSec": 1750606709833174,
  "lastPasswordChangeUSec": 1750606709833174,
  "privileged": {
    "hashedPassword": [
      "$y$j9T$ai2Fshq0ev9W05WL4SoRJ1$EFfe41ACrJKXMCQ83A05n6UW.HrRr9/O4b1x0CXgAXD"
    ]
  },
  "binding": {
    "c1082742b92c4f7e8d30d6b17f9d3351": {
      "blobDirectory": "/var/cache/systemd/home/foobarbaz",
      "uid": 60056,
      "gid": 60056
    }
  },
  "secret": {
    "password": [
      "test"
    ]
  },
  "__systemd_homework_internal_blob_fdmap": {}
}

(cherry picked from commit e248790263b63822cdffa399b593a272d7abddc8)
(cherry picked from commit a283e832dabd35d9f6e6aace0525ecf4f6372b57)
(cherry picked from commit bd71224be1cce183ea0b862ae702d0bb62873479)
(cherry picked from commit 49d2797)
(cherry picked from commit 528a943)
@poettering @bluca
console: when switching console modes and one doesn't work, always go…
b9d0cc5 
… for the next

So far we already had a logic in place to go for the next mode if some
mode doesn't work – but it was only applied if we'd actively cycle
through resolutions.

Let's extend the logic and always apply it: whenever we try to switch to
a mode, and it doesn't work, go to the next one until we find one that
works.

Fixes: #37324
(cherry picked from commit b53c3af3fe968fc2fc7631c9dab6737b08f0156a)
(cherry picked from commit 66235376a48d2d94bba6c5db0b9f5448243c2041)
(cherry picked from commit 5b3ab2f8a6650841cbac5823e0c6ccbd78096c84)
(cherry picked from commit b869d19)
(cherry picked from commit 261ae1f)
@bluca
test: escape '+' from uname -r before using in regex via '=~'
ecb0cac 
It will otherwise interpret characters such as '+' as if they
were regex, and break matching.

For example TEST-71-HOSTNAME started failing when
uname -r started including a '+':

FAIL: 'Kernel: Linux 6.12.33+deb13-amd64' not found in:
 Static hostname: host
       Icon name: computer-vm
         Chassis: vm 🖴
      Machine ID: e6471c1f95ab49098827498ed816cdf7
         Boot ID: 231da987f64d4af59f2076fbb638c611
  Virtualization: kvm
Operating System: Debian GNU/Linux 13 (trixie)
          Kernel: Linux 6.12.33+deb13-amd64
    Architecture: x86-64

(cherry picked from commit a0dfb0245662e31ded34730010e0e92be9bd9f1a)
(cherry picked from commit de5642b63e5c9210052b97105457a3debf5cc309)
(cherry picked from commit c6e94cb7910d5f12bd64c21cd4ed36499c6addf1)
(cherry picked from commit 359fed1)
(cherry picked from commit 5006511)
@bluca
hwdb: update to v257-stable@{2025-06-25}
5ae6aae 
git restore -s origin/v257-stable hwdb.d/ test/hwdb.d

(cherry picked from commit 244de7aee3181de8be64c1501eef0081d498f21c)
(cherry picked from commit 356c543)
(cherry picked from commit da2d44a)
@packit-as-a-service Packit-as-a-Service
Copy link

We were not able to find or create Copr project packit/systemd-systemd-stable-488 specified in the config with the following error:

Cannot create a new Copr project (owner=packit project=systemd-systemd-stable-488 chroots=[]): chroots: '[]' is not a valid choice for this field..

Unless the HTTP status code above is >= 500, please check your configuration for:

  1. typos in owner and project name (groups need to be prefixed with @)
  2. whether the project name doesn't contain not allowed characters (only letters, digits, underscores, dashes and dots must be used)
  3. whether the project itself exists (Packit creates projects only in its own namespace)
  4. whether Packit is allowed to build in your Copr project
  5. whether your Copr project/group is not private

@bluca bluca merged commit aecaee1 into systemd:v253-stable Jun 26, 2025
28 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@bluca @AdrianVovk @yuwata @MonterraByte @mugitya03 @poettering @gtsiam @lnykryn