feat(driver): Add support to be used as a separate storage driver

Author: Keerthan Mala

registry/storage/driver/gcs/gcs.go

@@ -10,12 +10,12 @@
 // Note that the contents of incomplete uploads are not accessible even though
 // Stat returns their length
 //
-// +build include_gcs
 
 package gcs
 
 import (
 	"bytes"
+	"encoding/json"
 	"fmt"
 	"io"
 	"io/ioutil"
@@ -34,6 +34,7 @@ import (
 	"golang.org/x/oauth2/google"
 	"golang.org/x/oauth2/jwt"
 	"google.golang.org/api/googleapi"
+	storageapi "google.golang.org/api/storage/v1"
 	"google.golang.org/cloud"
 	"google.golang.org/cloud/storage"
 
@@ -67,6 +68,7 @@ type driverParameters struct {
 	client        *http.Client
 	rootDirectory string
 	chunkSize     int
+	projectID     string
 }
 
 func init() {
@@ -132,6 +134,9 @@ func FromParameters(parameters map[string]interface{}) (storagedriver.StorageDri
 	}
 
 	var ts oauth2.TokenSource
+	var key struct {
+		ProjectID string `json:"project_id"`
+	}
 	jwtConf := new(jwt.Config)
 	if keyfile, ok := parameters["keyfile"]; ok {
 		jsonKey, err := ioutil.ReadFile(fmt.Sprint(keyfile))
@@ -142,6 +147,9 @@ func FromParameters(parameters map[string]interface{}) (storagedriver.StorageDri
 		if err != nil {
 			return nil, err
 		}
+		if err := json.Unmarshal(jsonKey, &key); err != nil {
+			return nil, err
+		}
 		ts = jwtConf.TokenSource(context.Background())
 	} else {
 		var err error
@@ -158,6 +166,7 @@ func FromParameters(parameters map[string]interface{}) (storagedriver.StorageDri
 		privateKey:    jwtConf.PrivateKey,
 		client:        oauth2.NewClient(context.Background(), ts),
 		chunkSize:     chunkSize,
+		projectID:     fmt.Sprint(key.ProjectID),
 	}
 
 	return New(params)
@@ -172,6 +181,17 @@ func New(params driverParameters) (storagedriver.StorageDriver, error) {
 	if params.chunkSize <= 0 || params.chunkSize%minChunkSize != 0 {
 		return nil, fmt.Errorf("Invalid chunksize: %d is not a positive multiple of %d", params.chunkSize, minChunkSize)
 	}
+
+	service, err := storageapi.New(params.client)
+	if err != nil {
+		return nil, err
+	}
+	if _, err := service.Buckets.Get(params.bucket).Do(); err != nil {
+		if _, err := service.Buckets.Insert(params.projectID, &storageapi.Bucket{Name: params.bucket}).Do(); err != nil {
+			return nil, err
+		}
+	}
+
 	d := &driver{
 		bucket:        params.bucket,
 		rootDirectory: rootDirectory,

registry/storage/driver/gcs/gcs_test.go

@@ -1,5 +1,3 @@
-// +build include_gcs
-
 package gcs
 
 import (
@@ -8,6 +6,7 @@ import (
 	"testing"
 
 	"fmt"
+
 	ctx "github.com/docker/distribution/context"
 	storagedriver "github.com/docker/distribution/registry/storage/driver"
 	"github.com/docker/distribution/registry/storage/driver/testsuites"

registry/storage/driver/s3-aws/s3.go

@@ -309,6 +309,23 @@ func New(params DriverParameters) (*Driver, error) {
 
 	s3obj := s3.New(session.New(awsConfig))
 
+	_, err := s3obj.CreateBucket(&s3.CreateBucketInput{
+		Bucket: &params.Bucket,
+	})
+	if err != nil {
+		if s3err, ok := err.(awserr.Error); ok {
+			if s3err.Code() != "BucketAlreadyOwnedByYou" && s3err.Code() != "BucketAlreadyExists" {
+				return nil, err
+			}
+		} else {
+			return nil, err
+		}
+	}
+
+	if err := s3obj.WaitUntilBucketExists(&s3.HeadBucketInput{Bucket: &params.Bucket}); err != nil {
+		return nil, err
+	}
+
 	// TODO Currently multipart uploads have no timestamps, so this would be unwise
 	// if you initiated a new s3driver while another one is running on the same bucket.
 	// multis, _, err := bucket.ListMulti("", "")

registry/storage/driver/storagedriver.go

@@ -110,7 +110,7 @@ type FileWriter interface {
 // number of path components separated by slashes, where each component is
 // restricted to alphanumeric characters or a period, underscore, or
 // hyphen.
-var PathRegexp = regexp.MustCompile(`^(/[A-Za-z0-9._-]+)+$`)
+var PathRegexp = regexp.MustCompile(`^([A-Za-z0-9._:-]*(/[A-Za-z0-9._:-]+)*)+$`)
 
 // ErrUnsupportedMethod may be returned in the case where a StorageDriver implementation does not support an optional method.
 type ErrUnsupportedMethod struct {