Skip to content

feat: support parallelstore csi driver #2203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 8, 2025

Conversation

DrFaust92
Copy link
Contributor

No description provided.

@DrFaust92 DrFaust92 requested review from ericyz, gtsorbo and a team as code owners December 7, 2024 23:16
@apeabody
Copy link
Collaborator

apeabody commented Dec 9, 2024

/gcbrun

Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @DrFaust92!

@apeabody apeabody self-assigned this Dec 13, 2024
@DrFaust92 DrFaust92 force-pushed the parallelstore branch 2 times, most recently from 9a0011c to 4db1d92 Compare December 16, 2024 23:33
@DrFaust92 DrFaust92 requested a review from apeabody December 16, 2024 23:33
@apeabody
Copy link
Collaborator

/gcbrun

@apeabody apeabody removed their assignment Feb 3, 2025
@apeabody
Copy link
Collaborator

apeabody commented Apr 7, 2025

/gcbrun

@apeabody
Copy link
Collaborator

apeabody commented Apr 7, 2025

From the INT test:

Error: Null condition

  on ../../../main.tf line 94, in locals:
  94:   parallelstore_csi_driver_config = var.parallelstore_csi_driver ? [{ enabled = true }] : []
    ├────────────────
    │ var.parallelstore_csi_driver is null

The condition value is null. Conditions must either be true or false.}

@DrFaust92
Copy link
Contributor Author

From the INT test:

Error: Null condition

  on ../../../main.tf line 94, in locals:
  94:   parallelstore_csi_driver_config = var.parallelstore_csi_driver ? [{ enabled = true }] : []
    ├────────────────
    │ var.parallelstore_csi_driver is null

The condition value is null. Conditions must either be true or false.}

I think i fixed it now, i addressed a previous comment but didnt address the nullability

@apeabody
Copy link
Collaborator

apeabody commented Apr 8, 2025

/gcbrun

@apeabody apeabody self-assigned this Apr 8, 2025
Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DrFaust92!

@apeabody apeabody merged commit ab9d4cb into terraform-google-modules:main Apr 8, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants