Fix 404 bug when trying to delete keys (#72)

* Update Dockerfile to use golang:bookworm and improve error handling in account existence check

* Refactor HTTP status code checks to use http.StatusOK and http.StatusNotFound for clarity

Author: therealpaulgg

Dockerfile.Debug

@@ -1,4 +1,4 @@
-FROM golang:buster
+FROM golang:bookworm
 RUN mkdir /app
 COPY ./pkg/ /app/pkg
 COPY . /app

pkg/actions/remove-machine.go

@@ -37,7 +37,7 @@ func RemoveMachine(c *cli.Context) error {
 	if err != nil {
 		return err
 	}
-	_, exists := lo.Find(machines, func(x dto.MachineDto) bool {
+	machine, exists := lo.Find(machines, func(x dto.MachineDto) bool {
 		return x.Name == answer
 	})
 	if !exists {
@@ -52,6 +52,6 @@ func RemoveMachine(c *cli.Context) error {
 	if answer != "y" {
 		return nil
 	}
-	err = retrieval.DeleteMachine(profile, answer)
+	err = retrieval.DeleteMachine(profile, machine.Name)
 	return err
 }

pkg/actions/setup.go

@@ -134,9 +134,12 @@ func checkIfAccountExists(username string, serverUrl *url.URL) (bool, error) {
 	if err != nil {
 		return false, err
 	}
-	if res.StatusCode == 404 {
+	if res.StatusCode == http.StatusNotFound {
 		return false, nil
 	}
+	if res.StatusCode != http.StatusOK {
+		return false, errors.New("failed to check if account exists. status code: " + strconv.Itoa(res.StatusCode))
+	}
 	return true, nil
 }
 
@@ -226,7 +229,7 @@ func newAccountSetup(serverUrl *url.URL) error {
 	if err != nil {
 		return err
 	}
-	if res.StatusCode != 200 {
+	if res.StatusCode != http.StatusOK {
 		return errors.New("failed to create user. status code: " + strconv.Itoa(res.StatusCode))
 	}
 	return nil

pkg/actions/upload.go

@@ -46,7 +46,7 @@ func Upload(c *cli.Context) error {
 	if err != nil {
 		return err
 	}
-	if res.StatusCode != 200 {
+	if res.StatusCode != http.StatusOK {
 		return errors.New("failed to get data. status code: " + strconv.Itoa(res.StatusCode))
 	}
 	masterKey, err := utils.RetrieveMasterKey()
@@ -125,7 +125,7 @@ func Upload(c *cli.Context) error {
 	if err != nil {
 		return err
 	}
-	if res2.StatusCode != 200 {
+	if res2.StatusCode != http.StatusOK {
 		return errors.New("failed to upload data. status code: " + strconv.Itoa(res2.StatusCode))
 	}
 	fmt.Println("Successfully uploaded keys.")

pkg/retrieval/data.go

@@ -29,7 +29,7 @@ func GetUserData(profile *models.Profile) (dto.DataDto, error) {
 	if err != nil {
 		return data, err
 	}
-	if res.StatusCode != 200 {
+	if res.StatusCode != http.StatusOK {
 		return data, errors.New("failed to get data. status code: " + strconv.Itoa(res.StatusCode))
 	}
 	if err := json.NewDecoder(res.Body).Decode(&data); err != nil {
@@ -65,7 +65,7 @@ func DeleteKey(profile *models.Profile, key dto.KeyDto) error {
 	if err != nil {
 		return err
 	}
-	if res.StatusCode != 200 {
+	if res.StatusCode != http.StatusOK {
 		return errors.New("failed to delete data. status code: " + strconv.Itoa(res.StatusCode))
 	}
 	return nil