New: lolstats - show League of Legends player data #3078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just the stub from pixlet create for now
Add a top row for player name and rank Then a row for the player total stats Then a row for last match and a bottom row with sequence of win/losses from recent matches. Requires configuring an API key from RIOT until we get our production key. It allows you to configure the summoner you want to show, otherwise picks from a few random famous players
Next StepsHello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:
Manual Review RequiredHang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:
|
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new app that shows League of Legends player data. It contains 4 rows:
Configuration allows you to set the summoner name, tagline and region. If not set, it will pick from a small pool of famous players to display.
Requires setting a RIOT API key (free to get for development but only lasts a day). Still working through the process to obtain a RIOT production key API and will put a follow up PR with it in the project.