Skip to content

Add road_closure to Traffic Incident #1857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from Mar 26, 2019
Merged

Add road_closure to Traffic Incident #1857

merged 2 commits into from Mar 26, 2019

Conversation

ghost
Copy link

@ghost ghost commented Mar 26, 2019

  • Adding road_closure for unplanned closures.
    For example serious serious event led to police closing the road.

- Adding road_closure for unplanned closures. 
  For example serious serious event led to police closing the road.
Copy link
Member

@nvkelso nvkelso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though the a-z ordering should be fixed before merge.

@@ -2314,6 +2314,7 @@ This **optional** layer is meant to be updated every few minutes, due to the hig
* `mass_transit`: a large amount of people are migrating from one location to another
* `planned_event`: an organised event is taking place causing disruption
* `road_hazard`: there are dangerous objects on the surface of the road
* `road_closure`: the road has been closed, e.g. police presence
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: please sort a-z with this line above road_hazard.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No probs. Done :)

@nvkelso nvkelso merged commit ab50435 into tilezen:master Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant