Merge pull request #401 from tomas/remove-on-socket-end

Remove on_socket_end callback

Author: tomas

lib/needle.js

@@ -575,15 +575,6 @@ Needle.prototype.send_request = function(count, method, uri, config, post_data,
     }, milisecs);
   }
 
-  // handle errors on the underlying socket, that may be closed while writing
-  // for an example case, see test/long_string_spec.js. we make sure this
-  // scenario ocurred by verifying the socket's writable & destroyed states.
-  function on_socket_end() {
-    if (returned && !this.writable && this.destroyed === false) {
-      this.destroy();
-      had_error(new Error('Remote end closed socket abruptly.'))
-    }
-  }
 
   debug('Making request #' + count, request_opts);
   request = protocol.request(request_opts, function(resp) {
@@ -833,7 +824,7 @@ Needle.prototype.send_request = function(count, method, uri, config, post_data,
     if (timer) clearTimeout(timer);
   })
 
-  // handle socket 'end' event to ensure we don't get delayed EPIPE errors.
+  // set response timeout once we get a valid socket
   request.once('socket', function(socket) {
     if (socket.connecting) {
       socket.once('connect', function() {
@@ -842,15 +833,6 @@ Needle.prototype.send_request = function(count, method, uri, config, post_data,
     } else {
       set_timeout('response', config.response_timeout);
     }
-
-    // socket.once('close', function(e) {
-    //   console.log('socket closed!', e);
-    // })
-
-    if (!socket.on_socket_end) {
-      socket.on_socket_end = on_socket_end;
-      socket.once('end', function() { process.nextTick(on_socket_end.bind(socket)) });
-    }
   })
 
   if (post_data) {