Skip to content

Resolves Issue 262 - CVE-2023-45133 - upgrade to latest babel traverse#266

Merged
ayusharma merged 1 commit into
trivago:mainfrom
c-h-russell-walker:main
Oct 23, 2023
Merged

Resolves Issue 262 - CVE-2023-45133 - upgrade to latest babel traverse#266
ayusharma merged 1 commit into
trivago:mainfrom
c-h-russell-walker:main

Conversation

@c-h-russell-walker
Copy link
Copy Markdown
Contributor

@c-h-russell-walker c-h-russell-walker commented Oct 22, 2023

This PR resolves this issue:
#262

The issue mentioned is that there a security warning issued for @babel/traverse package seen here:
https://security.snyk.io/vuln/SNYK-JS-BABELTRAVERSE-5962462

To create this PR I:

  • forked repo
  • cloned locally
  • updated package.json to be latest version of @babel/traverse
  • ran yarn
  • committed changes

Please let me know if there's anything I else can/need to do - like run tests etc. - thanks!

Updating to add that yarn type-check and yarn test pass as expected locally:

Screenshot 2023-10-22 at 7 27 27 PM

Copy link
Copy Markdown
Collaborator

@byara byara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for you contribution 🚀
We'll release this as soon as possible.

@ayusharma ayusharma merged commit 4f328cf into trivago:main Oct 23, 2023
@c-h-russell-walker
Copy link
Copy Markdown
Contributor Author

Thank you for you contribution 🚀

We'll release this as soon as possible.

Thanks so much for the quick release!

@sparrowt
Copy link
Copy Markdown

sparrowt commented Dec 7, 2023

Out of interest, why does this have to pin a specific version of @babel/traverse rather than using ^ or ~ to be more flexible?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants