[Format] Run prettier on most files#354
Merged
Merged
Conversation
This was referenced May 2, 2025
| ``` | ||
|
|
||
| **Note: There may be an issue with some package managers, such as `pnpm` or when using `prettier` v3.x. You can solve it by providing additional configuration option in prettier config file. | ||
| \*\*Note: There may be an issue with some package managers, such as `pnpm` or when using `prettier` v3.x. You can solve it by providing additional configuration option in prettier config file. |
Collaborator
There was a problem hiding this comment.
It changes result a little bit. I suppose it should be ** Note...
| import c from 'c' | ||
| ``` | ||
|
|
||
| ### Ignoring import ordering |
Collaborator
There was a problem hiding this comment.
Is this part supposed to be removed? I believe, it's better to keep it, since we provide this feature
Summary: ``` $ npx prettier --write . ``` Manually inspected changes, and reverted changes to examples, package.json, and tsconfig.json Test Plan: doitlive
Collaborator
|
Hey @vladislavarsenev, could you please take a Look at these PR as well. |
vladislavarsenev
force-pushed
the
pr354
branch
from
ec82cdf to
d9cae1b
Compare
vladislavarsenev
force-pushed
the
pr354
branch
from
868001e to
e5326ee
Compare
Collaborator
|
Thank you for your effort! I excluded *.md files from being prettified, since they might have code inside and sometimes should be wrong. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Manually inspected changes, and reverted changes to examples, package.json, and tsconfig.json
Test Plan: doitlive
Stack created with Sapling. Best reviewed with ReviewStack.
sort-imports-ignore#358