Switch to vitest for better ESM support#370
Conversation
I was still hitting issues with jest and trying to get full ESM support, so I decided to switch to vitest. This seems to be working and snapshots are generated essentially the same.
|
@vladislavarsenev @byara I went ahead and converted to vitest, which I think you had mentioned you wanted to do? It works a lot better with ESM it seems. |
| `; | ||
|
|
||
| exports[`sort-imports-ignored.ts - typescript-verify: sort-imports-ignored.ts 1`] = ` | ||
| exports[`ppsi.spec.js - typescript-verify > ppsi.spec.js 1`] = ` |
There was a problem hiding this comment.
It looks like was tested a file that wasn't supposed to be tested
There was a problem hiding this comment.
Ah yes, let me fix that.
|
Thanks for these changes! I left just one comment. |
|
@vladislavarsenev I fixed that issue. Thanks for calling it out! I think this is the last piece we need before I can actually work on the Ember gjs/gts support 🤞 |
|
Thanks for quick fix. One more thing is left. I tested it with and it didn't work with module resolution error. Take a look please what is wrong. It seems it was broken by |
|
@vladislavarsenev I am trying to debug that now, but have not been able to figure it out yet. Since the bug was introduced from another PR, could we go ahead and merge this and then fix the bug in its own PR perhaps? |
|
@vladislavarsenev I have figured out most of the issues and opened a PR to fix the examples here #371 Could we please merge this one and then I can rebase and fix the remaining issues? |
|
Ok, let's do this like that |
3 participants
I was still hitting issues with jest and trying to get full ESM support, so I decided to switch to vitest. This seems to be working and snapshots are generated essentially the same.