Add extensions to imports, fix some example issues#371
Conversation
RobbieTheWagner
force-pushed
the
fix-examples
branch
from
dadfc1d to
130ef6f
Compare
|
@vladislavarsenev it seems like something is wrong still. The prettier.config.js for the repo itself does not seem to work, and all of the examples have issues like |
|
@vladislavarsenev @byara I think I got all this sorted out now. We basically needed to make sure we had absolutely no CJS or |
|
@vladislavarsenev @byara please let me know if you would like any changes or if this looks good. I am eager to have all this resolved so I can work on gjs/gts support 😃 |
byara
left a comment
byara
left a comment
There was a problem hiding this comment.
This looks good to me. But if you don't mind I'll wait for @vladislavarsenev to have a final check.
|
Sure thing @byara! @vladislavarsenev please let me know if there are any additional changes you would like. |
|
@vladislavarsenev just wanted to bump this. Let me know if you would like any changes made please! |
|
@byara apologies for the multiple pings, but do you know if @vladislavarsenev is out? I am quite keen to get this merged so I can work on the gjs/gts support. |
Sorry @RobbieTheWagner, @vladislavarsenev was on vacation and today he is back. I'm sure he can take care of it 👍 |
|
Hi @RobbieTheWagner! Sorry, was unable to take a look PR for a while. I'll take a look tomorrow or so. Sounds good? |
|
Yes, thanks @vladislavarsenev! I appreciate you taking the time 😃 |
vladislavarsenev
left a comment
vladislavarsenev
left a comment
There was a problem hiding this comment.
LGTM🚀 I left just a few minor comments. Thank you for your effort!
3 participants
No description provided.