basic_engine_testsuite: Relax get_item_info expiry time assert

The get_item_info test in basic_engine_testsuite tries to check that
the returned expiry time is the same as the requested value, however
this is an incorrect use of the API.

The input value to item_allocate() is a memcache protocol time
(i.e. <30 days; treat as relative time from now, otherwise treat as
time since Unix epoch), but the `exptime` member of the item_info
struct is a rel_time_t - i.e. a time relative to when the memcached
server starts. For example if item_allocate() is called with an expiry
of '1', but the server has already been up for 5 seconds then
get_item_info() will return a exptime of '6' (assuming no time has
passed between the two calls).

Therefore relax the assert to just check that the returned value is
greater or equal to the requested value.

Fixes intermittant test failure in basic_engine_testsuite:

    assertion failed [ii.exptime == exp] at memcached/testsuite/basic/basic_engine_testsuite.cc:451
    Called from:
        platform/libplatform.so.0.1.0(cb_assert_die+0x66) [0x504bf66]
        basic_engine_testsuite.so() [0x7405c14]
        memcached/engine_testapp() [0x403570]
        /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xed) [0x56eb76d]
        memcached/engine_testapp() [0x4038fd]
    Killed

Change-Id: I18f765ae09772fe9c1dad631865d71c50f3cb739
Reviewed-on: http://review.couchbase.org/52706
Tested-by: buildbot <[email protected]>
Reviewed-by: Trond Norbye <[email protected]>

Author: daverigby

testsuite/basic/basic_engine_testsuite.cc

@@ -5,11 +5,46 @@
 #include <unistd.h>
 #include <platform/platform.h>
 #include "basic_engine_testsuite.h"
+
+#include <iostream>
 #include <vector>
 #include <sstream>
 
 struct test_harness test_harness;
 
+
+// Checks that a and b are equal; if not then assert.
+#define assert_equal(a, b) assert_equal_impl((a), (b), #a, #b, __FILE__, __LINE__)
+
+// Checkt that a >= b; if not then assert.
+#define assert_ge(a, b) assert_ge_impl((a), (b), #a, #b, __FILE__, __LINE__)
+
+template<typename T>
+static void assert_equal_impl(const T& a_value, const T& b_value,
+                              const char* a_name, const char* b_name,
+                              const char* file, int line) {
+    if (a_value != b_value) {
+        std::stringstream ss;
+        ss << "Check '" << a_name << " == " << b_name << "' failed - '"
+           << a_value << " == " << b_value << "' at " << file << ":" << line;
+        std::cerr << ss.str() << std::endl;
+        abort();
+    }
+}
+
+template<typename T>
+static void assert_ge_impl(const T& a_value, const T& b_value,
+                           const char* a_name, const char* b_name,
+                           const char* file, int line) {
+    if (a_value < b_value) {
+        std::stringstream ss;
+        ss << "Check '" << a_name << " >= " << b_name << "' failed - '"
+           << a_value << " >= " << b_value << "' at " << file << ":" << line;
+        std::cerr << ss.str() << std::endl;
+        abort();
+    }
+}
+
 /*
  * Make sure that get_info returns something and that repeated calls to it
  * return the same something.
@@ -443,12 +478,15 @@ static enum test_result get_item_info_test(ENGINE_HANDLE *h, ENGINE_HANDLE_V1 *h
     cb_assert(h1->store(h, NULL, test_item, &cas, OPERATION_SET,0) == ENGINE_SUCCESS);
     /* Had this been actual code, there'd be a connection here */
     cb_assert(h1->get_item_info(h, NULL, test_item, &ii) == true);
-    cb_assert(ii.cas == cas);
-    cb_assert(ii.flags == 0);
+    assert_equal(cas, ii.cas);
+    assert_equal(0u, ii.flags);
     cb_assert(strcmp(key,static_cast<const char*>(ii.key)) == 0);
-    cb_assert(ii.nkey == strlen(key));
-    cb_assert(ii.nbytes == 1);
-    cb_assert(ii.exptime == exp);
+    assert_equal(uint16_t(strlen(key)), ii.nkey);
+    assert_equal(1u, ii.nbytes);
+    // exptime is a rel_time_t; i.e. seconds since server started. Therefore can only
+    // check that the returned value is at least as large as the value
+    // we requested (i.e. not in the past).
+    assert_ge(ii.exptime, exp);
     h1->release(h, NULL, test_item);
     return SUCCESS;
 }