Skip to content

Commit 47a51ab

Browse files
authored
default ws close codes to 1001 in case they are undefined (Effect-TS#1743)
1 parent 51fe22f commit 47a51ab

3 files changed

Lines changed: 8 additions & 1 deletion

File tree

.changeset/sunny-bikes-sleep.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"effect": patch
3+
---
4+
5+
default ws close codes to 1001 in case they are undefined

packages/effect/src/unstable/socket/Socket.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -495,14 +495,15 @@ export const fromWebSocket = <RO>(
495495
)
496496
}
497497
function onClose(event: globalThis.CloseEvent) {
498+
const code = typeof event.code === "number" ? event.code : 1001
498499
ws.removeEventListener("message", onMessage)
499500
ws.removeEventListener("error", onError)
500501
Deferred.doneUnsafe(
501502
fiberSet.deferred,
502503
Effect.fail(
503504
new SocketError({
504505
reason: new SocketCloseError({
505-
code: event.code,
506+
code,
506507
closeReason: event.reason
507508
})
508509
})

packages/platform-bun/src/BunHttpServer.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,7 @@ export const make = Effect.fnUntraced(
8383
ws.data.run(message)
8484
},
8585
close(ws, code, closeReason) {
86+
code = typeof code === "number" ? code : 1001
8687
Deferred.doneUnsafe(
8788
ws.data.closeDeferred,
8889
Socket.defaultCloseCodeIsError(code)

0 commit comments

Comments
 (0)