Skip to content

Commit 0f9b90a

Browse files
authored
Remove unneeded formal parameter
1 parent 9fe9c72 commit 0f9b90a

File tree

3 files changed

+4
-9
lines changed

3 files changed

+4
-9
lines changed

framework/src/main/java/org/checkerframework/common/wholeprograminference/WholeProgramInference.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -130,9 +130,8 @@ void updateFromFormalParameterAssignment(
130130
* @param field the field whose type will be refined. Must be either a FieldAccessNode or a
131131
* LocalVariableNode whose element kind is FIELD.
132132
* @param rhs the expression being assigned to the field
133-
* @param classTree the ClassTree for the enclosing class of the assignment
134133
*/
135-
void updateFromFieldAssignment(Node field, Node rhs, ClassTree classTree);
134+
void updateFromFieldAssignment(Node field, Node rhs);
136135

137136
/**
138137
* Updates the type of {@code field} based on an assignment whose right-hand side has type {@code

framework/src/main/java/org/checkerframework/common/wholeprograminference/WholeProgramInferenceImplementation.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -423,7 +423,7 @@ public void updateFromFormalParameterAssignment(
423423
}
424424

425425
@Override
426-
public void updateFromFieldAssignment(Node lhs, Node rhs, ClassTree classTree) {
426+
public void updateFromFieldAssignment(Node lhs, Node rhs) {
427427

428428
Element element;
429429
String fieldName;

framework/src/main/java/org/checkerframework/framework/flow/CFAbstractTransfer.java

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -850,10 +850,7 @@ public TransferResult<V, S> visitAssignment(AssignmentNode n, TransferInput<V, S
850850
|| (lhs instanceof LocalVariableNode
851851
&& ((LocalVariableNode) lhs).getElement().getKind() == ElementKind.FIELD)) {
852852
// Updates inferred field type
853-
analysis
854-
.atypeFactory
855-
.getWholeProgramInference()
856-
.updateFromFieldAssignment(lhs, rhs, analysis.getContainingClass(n.getTree()));
853+
analysis.atypeFactory.getWholeProgramInference().updateFromFieldAssignment(lhs, rhs);
857854
} else if (lhs instanceof LocalVariableNode
858855
&& ((LocalVariableNode) lhs).getElement().getKind() == ElementKind.PARAMETER) {
859856
// lhs is a formal parameter of some method
@@ -926,8 +923,7 @@ && shouldPerformWholeProgramInference(n.getTree(), lhs.getTree())) {
926923
analysis
927924
.atypeFactory
928925
.getWholeProgramInference()
929-
.updateFromFieldAssignment(
930-
(FieldAccessNode) lhs, rhs, analysis.getContainingClass(n.getTree()));
926+
.updateFromFieldAssignment((FieldAccessNode) lhs, rhs);
931927
}
932928

933929
processCommonAssignment(in, lhs, rhs, store, resultValue);

0 commit comments

Comments
 (0)