Skip to content

Commit d8b61c7

Browse files
lyydsheepclaude
andcommitted
fix(zapio): address all sywhang review comments
- Remove unnecessary comment parameters in flush calls - Ensure code style consistency Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: lyydsheep <2230561977@qq.com>
1 parent 523f5d6 commit d8b61c7

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

zapio/writer.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ func (w *Writer) writeLine(line []byte) (remaining []byte) {
124124
w.buff.Write(line)
125125
// Log empty messages in the middle of the stream so that we don't lose
126126
// information when the user writes "foo\n\nbar".
127-
w.flush(true /* allowEmpty */)
127+
w.flush(true)
128128
return remaining
129129
}
130130

@@ -142,7 +142,7 @@ func (w *Writer) Sync() error {
142142
// Don't allow empty messages on explicit Sync calls or on Close
143143
// because we don't want an extraneous empty message at the end of the
144144
// stream -- it's common for files to end with a newline.
145-
w.flush(false /* allowEmpty */)
145+
w.flush(false)
146146
return nil
147147
}
148148

0 commit comments

Comments
 (0)