refactor: remove re-exports from game module to enforce proper separation

Remove TUI-related re-exports from presentation::game module and update
all import statements to use presentation::tui directly. This enforces
proper separation of concerns between game logic and TUI infrastructure.

Changes:
- Remove Screen, ScreenDataProvider, ScreenType, UpdateStrategy re-exports from game/mod.rs
- Remove ScreenTransition, ScreenTransitionManager re-exports from game/mod.rs
- Remove ScreenDataProvider re-exports from game/models/mod.rs
- Update all import statements in src/ to use presentation::tui for TUI types
- Update all import statements in tests/ to use presentation::tui for TUI types
- Separate game imports (GameData, SessionManager) from tui imports (Screen, ScreenType, etc.)

Breaking Change: External code using presentation::game::Screen or related
types must now import from presentation::tui instead.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

Author: unhappychoice

src/presentation/cli/commands/game.rs

@@ -5,10 +5,9 @@ use crate::domain::services::theme_manager::ThemeManager;
 use crate::domain::services::version_service::VersionService;
 use crate::infrastructure::logging;
 use crate::presentation::cli::args::Cli;
-use crate::presentation::game::models::ScreenType;
-use crate::presentation::tui::screen_manager::ScreenManager;
-use crate::presentation::tui::screens::{VersionCheckResult, VersionCheckScreen};
 use crate::presentation::game::{GameData, SessionManager};
+use crate::presentation::tui::{ScreenManager, ScreenType};
+use crate::presentation::tui::screens::{VersionCheckResult, VersionCheckScreen};
 use crate::presentation::signal_handler::setup_signal_handlers;
 use crate::{GitTypeError, Result};
 use std::path::PathBuf;

src/presentation/game/mod.rs

@@ -12,13 +12,5 @@ pub mod text_processor;
 pub mod typing_core;
 
 pub use game_data::GameData;
-pub use models::ScreenDataProvider;
 pub use session_manager::{SessionConfig, SessionManager, SessionState};
 pub use stage_repository::{GameMode, StageConfig, StageRepository};
-
-// Re-export from tui module for backward compatibility
-pub use crate::presentation::tui::{
-    Screen, ScreenManager, ScreenTransition, ScreenTransitionManager, ScreenType, UpdateStrategy,
-};
-pub use crate::presentation::tui::screens::TypingScreen;
-pub use crate::presentation::tui::views;

src/presentation/game/models/mod.rs

@@ -1,8 +1,3 @@
 pub mod loading_steps;
 
 pub use loading_steps::*;
-
-// Re-export from tui module for backward compatibility
-pub use crate::presentation::tui::{
-    Screen, ScreenDataProvider, ScreenTransition, ScreenType, UpdateStrategy,
-};

src/presentation/game/stage_repository.rs

@@ -1,6 +1,7 @@
 use crate::domain::models::{Challenge, DifficultyLevel, GitRepository};
+use crate::presentation::game::GameData;
+use crate::presentation::tui::{ScreenManager, ScreenType};
 use crate::presentation::tui::screens::TitleScreen;
-use crate::presentation::game::{GameData, ScreenManager, ScreenType};
 use crate::{GitTypeError, Result};
 use once_cell::sync::Lazy;
 use rand::rngs::StdRng;

src/presentation/signal_handler.rs

@@ -1,7 +1,6 @@
 use crate::infrastructure::logging::{log_error_to_file, log_panic_to_file};
 use crate::presentation::game::events::ExitRequested;
-use crate::presentation::game::models::Screen;
-use crate::presentation::tui::screen_manager::ScreenManager;
+use crate::presentation::tui::{Screen, ScreenManager};
 use crate::presentation::tui::screens::PanicScreen;
 use crate::GitTypeError;
 use crossterm::cursor::{Hide, Show};

src/presentation/tui/screens/analytics_screen.rs

@@ -4,7 +4,7 @@ use crate::presentation::game::events::NavigateTo;
 use crate::presentation::tui::views::analytics::{
     LanguagesView, OverviewView, RepositoriesView, TrendsView,
 };
-use crate::presentation::game::{Screen, ScreenDataProvider, ScreenType, UpdateStrategy};
+use crate::presentation::tui::{Screen, ScreenDataProvider, ScreenType, UpdateStrategy};
 use crate::presentation::ui::Colors;
 use crate::Result;
 use crossterm::event::{KeyCode, KeyModifiers};

src/presentation/tui/screens/animation_screen.rs

@@ -2,11 +2,10 @@ use crate::domain::events::EventBus;
 use crate::domain::models::{RankTier, SessionResult};
 use crate::domain::services::scoring::Rank;
 use crate::presentation::game::events::NavigateTo;
+use crate::presentation::game::SessionManager;
+use crate::presentation::tui::{Screen, ScreenDataProvider, ScreenType, UpdateStrategy};
 use crate::presentation::tui::views::typing::typing_animation_view::AnimationPhase;
 use crate::presentation::tui::views::TypingAnimationView;
-use crate::presentation::game::{
-    Screen, ScreenDataProvider, ScreenType, SessionManager, UpdateStrategy,
-};
 use crate::presentation::ui::Colors;
 use crate::{GitTypeError, Result};
 use crossterm::event::{KeyCode, KeyModifiers};

src/presentation/tui/screens/help_screen.rs

@@ -2,7 +2,7 @@ use crate::domain::events::EventBus;
 use crate::domain::models::rank::{Rank, RankTier};
 use crate::infrastructure::browser;
 use crate::presentation::game::events::NavigateTo;
-use crate::presentation::game::{Screen, ScreenDataProvider, ScreenType, UpdateStrategy};
+use crate::presentation::tui::{Screen, ScreenDataProvider, ScreenType, UpdateStrategy};
 use crate::presentation::ui::Colors;
 use crate::Result;
 use crossterm::event::{KeyCode, KeyModifiers};

src/presentation/tui/screens/info_dialog.rs

@@ -1,7 +1,7 @@
 use crate::domain::events::EventBus;
 use crate::infrastructure::browser;
 use crate::presentation::game::events::NavigateTo;
-use crate::presentation::game::{Screen, ScreenDataProvider, ScreenType, UpdateStrategy};
+use crate::presentation::tui::{Screen, ScreenDataProvider, ScreenType, UpdateStrategy};
 use crate::presentation::ui::Colors;
 use crate::Result;
 use crossterm::event::{KeyCode, KeyModifiers};

src/presentation/tui/screens/loading_screen.rs

@@ -3,8 +3,9 @@ use crate::domain::models::ExtractionOptions;
 use crate::domain::models::{Challenge, GitRepository};
 use crate::presentation::game::events::ExitRequested;
 use crate::presentation::game::models::{ExecutionContext, StepManager, StepType};
+use crate::presentation::game::GameData;
+use crate::presentation::tui::{Screen, ScreenDataProvider, ScreenType, UpdateStrategy};
 use crate::presentation::tui::views::LoadingMainView;
-use crate::presentation::game::{GameData, Screen, ScreenDataProvider, ScreenType, UpdateStrategy};
 use crate::{GitTypeError, Result};
 use ratatui::Frame;
 use std::path::PathBuf;