fix: address CodeRabbit review feedback

- Add missing 'Extracting' step name in step_manager_tests
- Clarify cache test independence in challenge_repository_tests
- Fix misleading comment about mistakes estimation in analytics_service_tests
- Fix Challenge::new argument order (id, code_content) in session_manager_service_tests
- Use specific 'Mistakes: 5' assertion instead of fragile '5' in sharing_tests
- Assert buffer content changes after Esc in info_dialog fallback test
- Replace silent failures with .expect() in screen_transition_manager helpers
- Remove unused Colors import in theme_manager_tests

Author: unhappychoice

tests/integration/screens/info_dialog_test.rs

@@ -287,14 +287,15 @@ fn test_info_dialog_fallback_esc_returns_to_menu() {
         )) as Arc<dyn ThemeServiceInterface>,
     );
 
-    // Verify fallback renders without panic
+    // Render fallback state
     let backend = TestBackend::new(120, 40);
     let mut terminal = Terminal::new(backend).unwrap();
-    terminal
+    let before = terminal
         .draw(|frame| {
             screen.render_ratatui(frame).unwrap();
         })
         .unwrap();
+    let before_buffer = before.buffer.clone();
 
     // Press Esc to return to Menu state
     screen
@@ -304,14 +305,20 @@ fn test_info_dialog_fallback_esc_returns_to_menu() {
         ))
         .unwrap();
 
-    // Render again - should now be in Menu state
+    // Render again - should now be in Menu state with different content
     let backend2 = TestBackend::new(120, 40);
     let mut terminal2 = Terminal::new(backend2).unwrap();
-    terminal2
+    let after = terminal2
         .draw(|frame| {
             screen.render_ratatui(frame).unwrap();
         })
         .unwrap();
+    let after_buffer = after.buffer.clone();
+
+    assert_ne!(
+        before_buffer, after_buffer,
+        "Rendered content should change after Esc transitions from Fallback to Menu"
+    );
 }
 
 // Test: Fallback state - Ctrl+C exits

tests/unit/domain/models/loading/step_manager_tests.rs

@@ -83,6 +83,7 @@ fn get_step_by_name_all_steps() {
         "Cloning repository",
         "Cache check",
         "Scanning repository",
+        "Extracting functions, classes, and code blocks",
         "Generating challenges",
         "Finalizing",
     ];

tests/unit/domain/repositories/challenge_repository_tests.rs

@@ -165,6 +165,7 @@ fn test_save_then_get_cache_stats() {
 
 #[test]
 fn test_save_then_clear_cache() {
+    // Each test uses its own repository instance to avoid shared state
     let repo = create_repository();
     let git_repo = create_test_repo(Some("clear-test".to_string()), false);
     let challenges = vec![create_test_challenge("t1", "fn main() {}")];
@@ -178,6 +179,7 @@ fn test_save_then_clear_cache() {
 
 #[test]
 fn test_save_then_list_cache_keys() {
+    // Each test uses its own repository instance to avoid shared state
     let repo = create_repository();
     repo.clear_cache().unwrap();
 

tests/unit/domain/services/analytics_service_tests.rs

@@ -445,6 +445,9 @@ fn test_analytics_best_cpm_tracked_across_sessions() {
 fn test_analytics_mistakes_estimation() {
     let mut mock = MockSessionRepo::new();
     mock.sessions = vec![make_session(1, None)];
+    // Note: make_result sets mistakes=5 on SessionResultData, but AnalyticsService
+    // computes total_mistakes from accuracy and stages_attempted, not from the
+    // mistakes field: (100 - accuracy) / 100 * stages_attempted → cast to usize.
     // 90% accuracy with 3 stages attempted → (100-90)/100 * 3 = 0.3 → 0 as usize
     mock.results = vec![(1, make_result(200.0, 90.0, 10000))];
     mock.stage_results = vec![(1, vec![])];

tests/unit/domain/services/session_manager_service_tests.rs

@@ -895,8 +895,8 @@ fn test_get_current_challenge_in_progress_with_challenges() {
 
     // Populate challenge store with challenges
     let challenges = vec![
-        Challenge::new("fn foo() {}".to_string(), "test.rs".to_string()),
-        Challenge::new("fn bar() {}".to_string(), "test.rs".to_string()),
+        Challenge::new("test-1".to_string(), "fn foo() {}".to_string()),
+        Challenge::new("test-2".to_string(), "fn bar() {}".to_string()),
     ];
     challenge_store.set_challenges(challenges);
 
@@ -934,8 +934,8 @@ fn test_get_next_challenge_in_progress_with_challenges() {
     let challenge_store = Arc::new(ChallengeStore::new_for_test());
 
     let challenges = vec![
-        Challenge::new("fn foo() {}".to_string(), "test.rs".to_string()),
-        Challenge::new("fn bar() {}".to_string(), "test.rs".to_string()),
+        Challenge::new("test-1".to_string(), "fn foo() {}".to_string()),
+        Challenge::new("test-2".to_string(), "fn bar() {}".to_string()),
     ];
     challenge_store.set_challenges(challenges);
 

tests/unit/domain/services/theme_manager_tests.rs

@@ -129,8 +129,6 @@ fn get_current_color_scheme_returns_light_scheme() {
 
 #[test]
 fn get_colors_returns_valid_colors() {
-    use gittype::presentation::ui::Colors;
-
     let manager = create_theme_service();
     let colors = manager.get_colors();
     let _ = colors.border();

tests/unit/presentation/sharing_tests.rs

@@ -63,7 +63,10 @@ fn create_share_text_without_repo() {
 
     assert!(text.contains("150"), "should contain score");
     assert!(text.contains("300"), "should contain cpm");
-    assert!(text.contains("5"), "should contain total mistakes (3+2)");
+    assert!(
+        text.contains("Mistakes: 5"),
+        "should contain total mistakes (3+2)"
+    );
     assert!(text.contains("#gittype"));
     assert!(text.contains("github.com/unhappychoice/gittype"));
     // Should NOT contain repo info

tests/unit/presentation/tui/screen_transition_manager_tests.rs

@@ -499,33 +499,38 @@ mod tests {
 
     fn start_session(sm: &Arc<dyn SessionManagerInterface>) {
         // Start the game via Title→Typing transition
-        let _ = ScreenTransitionManager::reduce(ScreenType::Title, ScreenType::Typing, sm);
+        ScreenTransitionManager::reduce(ScreenType::Title, ScreenType::Typing, sm)
+            .expect("Title→Typing transition should succeed");
     }
 
     fn set_git_repository(sm: &Arc<dyn SessionManagerInterface>) {
         use gittype::domain::models::GitRepository;
-        if let Some(concrete_sm) = sm.as_any().downcast_ref::<SessionManager>() {
-            concrete_sm.set_git_repository(Some(GitRepository {
-                user_name: "test".to_string(),
-                repository_name: "repo".to_string(),
-                remote_url: "https://github.com/test/repo".to_string(),
-                branch: Some("main".to_string()),
-                commit_hash: Some("abc123def456".to_string()),
-                is_dirty: false,
-                root_path: None,
-            }));
-        }
+        let concrete_sm = sm
+            .as_any()
+            .downcast_ref::<SessionManager>()
+            .expect("should downcast to SessionManager");
+        concrete_sm.set_git_repository(Some(GitRepository {
+            user_name: "test".to_string(),
+            repository_name: "repo".to_string(),
+            remote_url: "https://github.com/test/repo".to_string(),
+            branch: Some("main".to_string()),
+            commit_hash: Some("abc123def456".to_string()),
+            is_dirty: false,
+            root_path: None,
+        }));
     }
 
     fn start_session_with_tracker(sm: &Arc<dyn SessionManagerInterface>) {
         use gittype::domain::services::scoring::StageTracker;
 
         start_session(sm);
         // Set up a stage tracker so handle_game_failure can use it
-        if let Some(concrete_sm) = sm.as_any().downcast_ref::<SessionManager>() {
-            let tracker = StageTracker::new("test challenge".to_string());
-            concrete_sm.set_current_stage_tracker(tracker);
-        }
+        let concrete_sm = sm
+            .as_any()
+            .downcast_ref::<SessionManager>()
+            .expect("should downcast to SessionManager");
+        let tracker = StageTracker::new("test challenge".to_string());
+        concrete_sm.set_current_stage_tracker(tracker);
     }
 
     #[test]