Improve inline element handling #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now we can use jasmine 2.0 and its improved async spec handling.
It seems the focus event is not triggered and thus we cannot properly test this.
The log has to be disabled globally. With the current implementation of log a per instance setting is not possible.
Firefox does not render empty block level elements so we have to add a line-break so things are rendered properly. The zeroWidthNonBreakingSpace showed some issues in Firefox so I removed it completely. Hopefully the line-break also helps with inline elements.
The traversal through all nodes in an editable was buggy.
peyerluk
added a commit
that referenced
this pull request
Jun 11, 2014
Improve inline element handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inline elements collapse to zero height and the cursor is not displayed by default.